Skip to content

Commit bb8c5dd

Browse files
cweichen-ddcweichen-dd
committed
Fixed failing tests with duckdb db name
1 parent 6f2cf9e commit bb8c5dd

9 files changed

+143
-15
lines changed

‎tests/contrib/duckdb/test_duckdb_comprehensive.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def test_simple_query(self):
4747
assert span.name == "duckdb.query"
4848
assert span.span_type == "sql"
4949
assert span.error == 0
50-
assert span.get_tag("db.name") == "memory"
50+
assert span.get_tag("db.name") == ":memory:"
5151

5252
def test_parameterized_query(self):
5353
"""Test parameterized queries with different parameter styles"""

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_analytical_query_performance.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "688d072100000000",
1515
"component": "duckdb",
16-
"db.name": "memory",
16+
"db.name": ":memory:",
1717
"db.system": "duckdb",
1818
"language": "python",
1919
"runtime-id": "166d9fa48ea14027a57a390c8b9c1c3e",
@@ -45,7 +45,7 @@
4545
"_dd.p.dm": "-0",
4646
"_dd.p.tid": "688d072100000000",
4747
"component": "duckdb",
48-
"db.name": "memory",
48+
"db.name": ":memory:",
4949
"db.system": "duckdb",
5050
"language": "python",
5151
"runtime-id": "166d9fa48ea14027a57a390c8b9c1c3e",

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_bulk_insert_performance.json‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "688cd32500000000",
1515
"component": "duckdb",
16-
"db.name": "memory",
16+
"db.name": ":memory:",
1717
"db.system": "duckdb",
1818
"language": "python",
1919
"runtime-id": "b18a2d2cad0c469eac9837ec0078168a",
@@ -46,7 +46,7 @@
4646
"_dd.p.dm": "-0",
4747
"_dd.p.tid": "688cd32600000000",
4848
"component": "duckdb",
49-
"db.name": "memory",
49+
"db.name": ":memory:",
5050
"db.system": "duckdb",
5151
"language": "python",
5252
"runtime-id": "b18a2d2cad0c469eac9837ec0078168a",
@@ -78,7 +78,7 @@
7878
"_dd.p.dm": "-0",
7979
"_dd.p.tid": "688cd32500000000",
8080
"component": "duckdb",
81-
"db.name": "memory",
81+
"db.name": ":memory:",
8282
"db.system": "duckdb",
8383
"language": "python",
8484
"runtime-id": "b18a2d2cad0c469eac9837ec0078168a",

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_complex_query.json‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "688cd65300000000",
1515
"component": "duckdb",
16-
"db.name": "memory",
16+
"db.name": ":memory:",
1717
"db.system": "duckdb",
1818
"language": "python",
1919
"runtime-id": "db000cc97b524d1c8a15b66197e11641",
@@ -45,7 +45,7 @@
4545
"_dd.p.dm": "-0",
4646
"_dd.p.tid": "688cd65300000000",
4747
"component": "duckdb",
48-
"db.name": "memory",
48+
"db.name": ":memory:",
4949
"db.system": "duckdb",
5050
"language": "python",
5151
"runtime-id": "db000cc97b524d1c8a15b66197e11641",

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_error_handling.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "688a5fb800000000",
1515
"component": "duckdb",
16-
"db.name": "memory",
16+
"db.name": ":memory:",
1717
"db.system": "duckdb",
1818
"error.message": "Catalog Error: Table with name non_existent_table does not exist!\nDid you mean \"sqlite_temp_master\"?\n\nLINE 1: SELECT * FROM non_existent_table\n ^",
1919
"error.type": "duckdb.duckdb.CatalogException",

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_fetch_methods.json‎

Lines changed: 96 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,96 @@
1+
[[
2+
{
3+
"name": "duckdb.query",
4+
"service": "duckdb",
5+
"resource": "CREATE TABLE test_fetch (id INTEGER, name VARCHAR)",
6+
"trace_id": 0,
7+
"span_id": 1,
8+
"parent_id": 0,
9+
"type": "sql",
10+
"error": 0,
11+
"meta": {
12+
"_dd.base_service": "ddtrace_subprocess_dir",
13+
"_dd.p.dm": "-0",
14+
"_dd.p.tid": "68935f6800000000",
15+
"component": "duckdb",
16+
"db.name": ":memory:",
17+
"db.system": "duckdb",
18+
"language": "python",
19+
"runtime-id": "0989cc97d2c941b58151a91dd33ad8f5",
20+
"span.kind": "client"
21+
},
22+
"metrics": {
23+
"_dd.measured": 1,
24+
"_dd.top_level": 1,
25+
"_dd.tracer_kr": 1.0,
26+
"_sampling_priority_v1": 1,
27+
"db.row_count": -1,
28+
"process_id": 10546
29+
},
30+
"duration": 1108000,
31+
"start": 1754488680796798251
32+
}],
33+
[
34+
{
35+
"name": "duckdb.query",
36+
"service": "duckdb",
37+
"resource": "INSERT INTO test_fetch VALUES (1, 'Alice'), (2, 'Bob'), (3, 'Charlie')",
38+
"trace_id": 1,
39+
"span_id": 1,
40+
"parent_id": 0,
41+
"type": "sql",
42+
"error": 0,
43+
"meta": {
44+
"_dd.base_service": "ddtrace_subprocess_dir",
45+
"_dd.p.dm": "-0",
46+
"_dd.p.tid": "68935f6800000000",
47+
"component": "duckdb",
48+
"db.name": ":memory:",
49+
"db.system": "duckdb",
50+
"language": "python",
51+
"runtime-id": "0989cc97d2c941b58151a91dd33ad8f5",
52+
"span.kind": "client"
53+
},
54+
"metrics": {
55+
"_dd.measured": 1,
56+
"_dd.top_level": 1,
57+
"_dd.tracer_kr": 1.0,
58+
"_sampling_priority_v1": 1,
59+
"db.row_count": -1,
60+
"process_id": 10546
61+
},
62+
"duration": 962583,
63+
"start": 1754488680798101126
64+
}],
65+
[
66+
{
67+
"name": "duckdb.query",
68+
"service": "duckdb",
69+
"resource": "SELECT * FROM test_fetch",
70+
"trace_id": 2,
71+
"span_id": 1,
72+
"parent_id": 0,
73+
"type": "sql",
74+
"error": 0,
75+
"meta": {
76+
"_dd.base_service": "ddtrace_subprocess_dir",
77+
"_dd.p.dm": "-0",
78+
"_dd.p.tid": "68935f6800000000",
79+
"component": "duckdb",
80+
"db.name": ":memory:",
81+
"db.system": "duckdb",
82+
"language": "python",
83+
"runtime-id": "0989cc97d2c941b58151a91dd33ad8f5",
84+
"span.kind": "client"
85+
},
86+
"metrics": {
87+
"_dd.measured": 1,
88+
"_dd.top_level": 1,
89+
"_dd.tracer_kr": 1.0,
90+
"_sampling_priority_v1": 1,
91+
"db.row_count": -1,
92+
"process_id": 10546
93+
},
94+
"duration": 173167,
95+
"start": 1754488680799119251
96+
}]]

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_multiple_sequential_queries.json‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "688d024f00000000",
1515
"component": "duckdb",
16-
"db.name": "memory",
16+
"db.name": ":memory:",
1717
"db.system": "duckdb",
1818
"language": "python",
1919
"runtime-id": "eb675bcc71c14217a665b9b2b29d993c",
@@ -45,7 +45,7 @@
4545
"_dd.p.dm": "-0",
4646
"_dd.p.tid": "688d024f00000000",
4747
"component": "duckdb",
48-
"db.name": "memory",
48+
"db.name": ":memory:",
4949
"db.system": "duckdb",
5050
"language": "python",
5151
"runtime-id": "eb675bcc71c14217a665b9b2b29d993c",
@@ -77,7 +77,7 @@
7777
"_dd.p.dm": "-0",
7878
"_dd.p.tid": "688d024f00000000",
7979
"component": "duckdb",
80-
"db.name": "memory",
80+
"db.name": ":memory:",
8181
"db.system": "duckdb",
8282
"language": "python",
8383
"runtime-id": "eb675bcc71c14217a665b9b2b29d993c",
@@ -109,7 +109,7 @@
109109
"_dd.p.dm": "-0",
110110
"_dd.p.tid": "688d024f00000000",
111111
"component": "duckdb",
112-
"db.name": "memory",
112+
"db.name": ":memory:",
113113
"db.system": "duckdb",
114114
"language": "python",
115115
"runtime-id": "eb675bcc71c14217a665b9b2b29d993c",
@@ -141,7 +141,7 @@
141141
"_dd.p.dm": "-0",
142142
"_dd.p.tid": "688d024f00000000",
143143
"component": "duckdb",
144-
"db.name": "memory",
144+
"db.name": ":memory:",
145145
"db.system": "duckdb",
146146
"language": "python",
147147
"runtime-id": "eb675bcc71c14217a665b9b2b29d993c",

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_parameterized_query.json‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
[[
2+
{
3+
"name": "duckdb.query",
4+
"service": "duckdb",
5+
"resource": "SELECT ? as value",
6+
"trace_id": 0,
7+
"span_id": 1,
8+
"parent_id": 0,
9+
"type": "sql",
10+
"error": 0,
11+
"meta": {
12+
"_dd.base_service": "ddtrace_subprocess_dir",
13+
"_dd.p.dm": "-0",
14+
"_dd.p.tid": "68935f6800000000",
15+
"component": "duckdb",
16+
"db.name": ":memory:",
17+
"db.system": "duckdb",
18+
"language": "python",
19+
"runtime-id": "b880395928484058a3d7f4bfa09ff023",
20+
"span.kind": "client"
21+
},
22+
"metrics": {
23+
"_dd.measured": 1,
24+
"_dd.top_level": 1,
25+
"_dd.tracer_kr": 1.0,
26+
"_sampling_priority_v1": 1,
27+
"db.row_count": -1,
28+
"process_id": 10526
29+
},
30+
"duration": 1675917,
31+
"start": 1754488680459278042
32+
}]]

‎tests/snapshots/test_duckdb_snapshot.test_duckdb_simple_query.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"_dd.p.dm": "-0",
1414
"_dd.p.tid": "688a5fb800000000",
1515
"component": "duckdb",
16-
"db.name": "memory",
16+
"db.name": ":memory:",
1717
"db.system": "duckdb",
1818
"language": "python",
1919
"runtime-id": "ece652173dad4112bb91cb93a5a0b285",

0 commit comments

Comments
 (0)