llmobs: keep context active when parent id is malformed #15197
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- activate a fallback LLMObs context when distributed headers carry a non-int parent id, preserving propagated llmobs trace id / ml app metadata and still recording the `invalid_parent_id` telemetry error - add regression coverage in `tests/llmobs/test_llmobs_service.py` to assert the fallback context is activated and telemetry is reported for both with/without propagated trace id Signed-off-by: jitokim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
invalid_parent_idtelemetry errortests/llmobs/test_llmobs_service.pyto assert the fallback context is activated and telemetry is reported for both with/without propagated trace idDescription
Testing
Risks
Additional Notes