-
Notifications
You must be signed in to change notification settings - Fork 467
chore: fix service management in scripts/run-tests #15211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 242 ± 4 ms. The average import time from base is: 246 ± 4 ms. The import time difference between this PR and base is: -3.4 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate brettlangdon/run-tests.service-management (d1159c5) with baseline main (a139e88) 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.461ms (SLO: <22.300ms -8.2%) vs baseline: -0.2% Memory: ✅ 66.187MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ exception-replay-enabledTime: ✅ 1.341ms (SLO: <1.450ms -7.5%) vs baseline: +0.2% Memory: ✅ 64.274MB (SLO: <67.000MB -4.1%) vs baseline: +5.0% ✅ iastTime: ✅ 20.412ms (SLO: <22.250ms -8.3%) vs baseline: -0.5% Memory: ✅ 66.148MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.568ms (SLO: <16.550ms -5.9%) vs baseline: +0.3% Memory: ✅ 53.980MB (SLO: <54.500MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.517ms (SLO: <21.750ms -5.7%) vs baseline: -0.4% Memory: ✅ 66.175MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.1% ✅ span-code-originTime: ✅ 25.333ms (SLO: <28.200ms 📉 -10.2%) vs baseline: -0.4% Memory: ✅ 67.222MB (SLO: <69.500MB -3.3%) vs baseline: +5.1% ✅ tracerTime: ✅ 20.379ms (SLO: <21.750ms -6.3%) vs baseline: -0.7% Memory: ✅ 66.046MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.649ms (SLO: <23.500ms -3.6%) vs baseline: -0.4% Memory: ✅ 67.988MB (SLO: <68.000MB 🟡 ~same) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.327ms (SLO: <21.500ms 📉 -10.1%) vs baseline: ~same Memory: ✅ 65.981MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.636ms (SLO: <17.500ms -4.9%) vs baseline: +0.2% Memory: ✅ 65.953MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.505ms (SLO: <21.750ms -5.7%) vs baseline: +0.1% Memory: ✅ 67.928MB (SLO: <72.500MB -6.3%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.475ms (SLO: <19.650ms -6.0%) vs baseline: -0.1% Memory: ✅ 66.043MB (SLO: <67.000MB 🟡 -1.4%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.777ms (SLO: <20.100ms -6.6%) vs baseline: ~same Memory: ✅ 65.956MB (SLO: <67.000MB 🟡 -1.6%) vs baseline: +4.7% ✅ tracer-no-middlewareTime: ✅ 20.158ms (SLO: <21.500ms -6.2%) vs baseline: -0.1% Memory: ✅ 65.993MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.280ms (SLO: <22.000ms -7.8%) vs baseline: ~same Memory: ✅ 65.992MB (SLO: <67.000MB 🟡 -1.5%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.170ms (SLO: <19.850ms -8.5%) vs baseline: +0.6% Memory: ✅ 65.942MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +4.7% ✅ errortracking-enabled-userTime: ✅ 18.279ms (SLO: <19.400ms -5.8%) vs baseline: +1.2% Memory: ✅ 65.906MB (SLO: <66.500MB 🟡 -0.9%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 18.237ms (SLO: <19.450ms -6.2%) vs baseline: +0.7% Memory: ✅ 65.957MB (SLO: <66.500MB 🟡 -0.8%) vs baseline: +5.0% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.100ms (SLO: <2.300ms -8.7%) vs baseline: +1.4% Memory: ✅ 52.396MB (SLO: <53.500MB -2.1%) vs baseline: +4.4% ✅ errortracking-enabled-userTime: ✅ 2.074ms (SLO: <2.250ms -7.8%) vs baseline: +0.4% Memory: ✅ 52.435MB (SLO: <53.500MB 🟡 -2.0%) vs baseline: +4.6% ✅ tracer-enabledTime: ✅ 2.065ms (SLO: <2.300ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 52.416MB (SLO: <53.500MB -2.0%) vs baseline: +4.5% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.3%) vs baseline: ~same Memory: ✅ 62.255MB (SLO: <65.000MB -4.2%) vs baseline: +4.7% ✅ appsec-postTime: ✅ 6.633ms (SLO: <6.750ms 🟡 -1.7%) vs baseline: ~same Memory: ✅ 62.311MB (SLO: <65.000MB -4.1%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.601ms (SLO: <4.750ms -3.1%) vs baseline: +0.3% Memory: ✅ 62.284MB (SLO: <65.000MB -4.2%) vs baseline: +4.8% ✅ debuggerTime: ✅ 1.856ms (SLO: <2.000ms -7.2%) vs baseline: ~same Memory: ✅ 45.220MB (SLO: <47.000MB -3.8%) vs baseline: +4.7% ✅ iast-getTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: +0.2% Memory: ✅ 42.093MB (SLO: <49.000MB 📉 -14.1%) vs baseline: +4.6% ✅ profilerTime: ✅ 1.926ms (SLO: <2.100ms -8.3%) vs baseline: +0.5% Memory: ✅ 46.675MB (SLO: <47.000MB 🟡 -0.7%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.364ms (SLO: <3.650ms -7.8%) vs baseline: ~same Memory: ✅ 52.577MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.8% ✅ tracerTime: ✅ 3.356ms (SLO: <3.650ms -8.1%) vs baseline: +0.1% Memory: ✅ 52.563MB (SLO: <53.500MB 🟡 -1.8%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 3.359ms (SLO: <3.650ms -8.0%) vs baseline: +0.3% Memory: ✅ 54.345MB (SLO: <60.000MB -9.4%) vs baseline: +4.9% 🟡 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.990µs (SLO: <20.000µs 📉 -85.0%) vs baseline: -0.5% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +5.0% ✅ 1-count-metrics-100-timesTime: ✅ 206.093µs (SLO: <220.000µs -6.3%) vs baseline: +0.6% Memory: ✅ 31.949MB (SLO: <34.000MB -6.0%) vs baseline: +5.0% ✅ 1-distribution-metric-1-timesTime: ✅ 3.288µs (SLO: <20.000µs 📉 -83.6%) vs baseline: -0.5% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.9% ✅ 1-distribution-metrics-100-timesTime: ✅ 217.505µs (SLO: <220.000µs 🟡 -1.1%) vs baseline: +1.1% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9% ✅ 1-gauge-metric-1-timesTime: ✅ 2.195µs (SLO: <20.000µs 📉 -89.0%) vs baseline: -0.8% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.468µs (SLO: <150.000µs -8.4%) vs baseline: +0.6% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.127µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +0.2% Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 216.567µs (SLO: <250.000µs 📉 -13.4%) vs baseline: +0.1% Memory: ✅ 31.870MB (SLO: <34.000MB -6.3%) vs baseline: +4.7% ✅ 100-count-metrics-100-timesTime: ✅ 21.019ms (SLO: <22.000ms -4.5%) vs baseline: +1.2% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.256ms (SLO: <2.300ms 🟡 -1.9%) vs baseline: +1.1% Memory: ✅ 31.929MB (SLO: <34.000MB -6.1%) vs baseline: +5.1% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.428ms (SLO: <1.550ms -7.9%) vs baseline: +1.2% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ 100-rate-metrics-100-timesTime: ✅ 2.243ms (SLO: <2.550ms 📉 -12.0%) vs baseline: +1.1% Memory: ✅ 31.890MB (SLO: <34.000MB -6.2%) vs baseline: +4.8% ✅ flush-1-metricTime: ✅ 4.661µs (SLO: <20.000µs 📉 -76.7%) vs baseline: +3.1% Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.9% ✅ flush-100-metricsTime: ✅ 176.544µs (SLO: <250.000µs 📉 -29.4%) vs baseline: ~same Memory: ✅ 31.909MB (SLO: <34.000MB -6.1%) vs baseline: +4.7% ✅ flush-1000-metricsTime: ✅ 2.150ms (SLO: <2.500ms 📉 -14.0%) vs baseline: -0.4% Memory: ✅ 32.755MB (SLO: <34.500MB -5.1%) vs baseline: +5.2%
|
Description
When running
scripts/run-tests --venv <hash>the script would not auto-start docker services or addDD_TRACE_AGENT_URLenv var.This fixes that.
Apologies, the noise is because I ran formatting on the file.
Testing
Risks
Additional Notes