Skip to content

Conversation

@vpellan
Copy link
Contributor

@vpellan vpellan commented Oct 22, 2025

⚠️ DO NOT MERGE ⚠️

@github-actions
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-10-22 11:28:33 UTC

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Oct 22, 2025
@github-actions
Copy link

Typing analysis

Ignored files

This PR introduces 1 ignored file. It increases the percentage of typed files from 35.91% to 36.47% (+0.56%).

Ignored files (+1-0)Introduced:
lib/datadog/tracing/contrib/karafka/framework.rb

@datadog-official
Copy link

datadog-official bot commented Oct 22, 2025

⚠️ Tests

⚠️ Warnings

❄️ 3 New flaky tests detected

Auto Instrumentation of non Rails request which runs a query auto_instruments all relevant gems automatically from rspec (Datadog)
Missing DD_TRACE_WATERDROP_ENABLED env/configuration in "supported-configurations.json" file. See docs/AccessEnvironmentVariables.md for details.

Failure/Error: raise "Missing #{name} env/configuration in \"supported-configurations.json\" file. See docs/AccessEnvironmentVariables.md for details."

RuntimeError:
  Missing DD_TRACE_WATERDROP_ENABLED env/configuration in "supported-configurations.json" file. See docs/AccessEnvironmentVariables.md for details.
./lib/datadog/core/configuration/config_helper.rb:65:in \`get_environment_variable'
./lib/datadog/core/configuration/config_helper.rb:25:in \`[]'
./lib/datadog/core/configuration/option.rb:333:in \`get_value_from_env'
./lib/datadog/core/configuration/option.rb:309:in \`set_env_value'
...

    Hanami instrumentation when given a GET /books endpoint creates 4 spans from rspec

Profiler startup starts the profiler from rspec (Datadog)
Missing DD_TRACE_WATERDROP_ENABLED env/configuration in "supported-configurations.json" file. See docs/AccessEnvironmentVariables.md for details.

Failure/Error: raise "Missing #{name} env/configuration in \"supported-configurations.json\" file. See docs/AccessEnvironmentVariables.md for details."

RuntimeError:
  Missing DD_TRACE_WATERDROP_ENABLED env/configuration in "supported-configurations.json" file. See docs/AccessEnvironmentVariables.md for details.
./lib/datadog/core/configuration/config_helper.rb:65:in 'get_environment_variable'
./lib/datadog/core/configuration/config_helper.rb:25:in '[]'
./lib/datadog/core/configuration/option.rb:333:in 'get_value_from_env'
./lib/datadog/core/configuration/option.rb:309:in 'set_env_value'
...

🧪 5 Tests failed

Datadog::Tracing::Contrib::AutoInstrument when auto patching is included configurations application correctly from rspec (Datadog)
STDOUT:\`\` STDERR:\`/__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/config_helper.rb:65:in \`get_environment_variable': Missing DD_TRACE_WATERDROP_ENABLED env/configuration in "supported-configurations.json" file. See docs/AccessEnvironmentVariables.md for details. (RuntimeError)
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/config_helper.rb:25:in \`[]'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/option.rb:333:in \`get_value_from_env'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/option.rb:309:in \`set_env_value'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/option.rb:144:in \`get'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/options.rb:84:in \`get_option'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/options.rb:47:in \`block in default_helpers'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/extensions.rb:181:in \`instrument'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/auto_instrument.rb:44:in \`block (2 levels) in patch_all!'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/auto_instrument.rb:43:in \`each'
...
Datadog::Tracing::Contrib::AutoInstrument when auto patching is included sets default database from rspec (Datadog)
STDOUT:\`\` STDERR:\`/__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/config_helper.rb:65:in \`get_environment_variable': Missing DD_TRACE_WATERDROP_ENABLED env/configuration in "supported-configurations.json" file. See docs/AccessEnvironmentVariables.md for details. (RuntimeError)
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/config_helper.rb:25:in \`[]'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/option.rb:333:in \`get_value_from_env'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/option.rb:309:in \`set_env_value'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/option.rb:144:in \`get'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/options.rb:84:in \`get_option'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/core/configuration/options.rb:47:in \`block in default_helpers'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/extensions.rb:181:in \`instrument'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/auto_instrument.rb:44:in \`block (2 levels) in patch_all!'
	from /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/auto_instrument.rb:43:in \`each'
...
Datadog::Tracing::Contrib ensures /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/waterdrop/integration.rb is loaded from rspec (Datadog)
key not found: "waterdrop"

Failure/Error: ruby_module = mapping.fetch(directory) # raise key error if not found

KeyError:
  key not found: "waterdrop"
./spec/datadog/tracing/contrib_spec.rb:63:in 'Hash#fetch'
./spec/datadog/tracing/contrib_spec.rb:63:in 'block (4 levels) in <top (required)>'
./spec/spec_helper.rb:272:in 'block (2 levels) in <top (required)>'
./spec/spec_helper.rb:154:in 'block (2 levels) in <top (required)>'
...
View all
This comment will be updated automatically if new data arrives.
🔗 Commit SHA: a51106d | Docs | Was this helpful? Give us feedback!

@pr-commenter
Copy link

pr-commenter bot commented Oct 22, 2025

Benchmarks

Benchmark execution time: 2025-10-22 11:55:52

Comparing candidate commit a51106d in PR branch community/pr-4874 with baseline commit 2f20b9a in branch master.

Found 1 performance improvements and 1 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics.

scenario:error - without error tracking, with_error=false

  • 🟥 throughput [-680.204op/s; -636.280op/s] or [-5.511%; -5.155%]

scenario:profiling - Allocations (baseline)

  • 🟩 throughput [+261453.577op/s; +275412.077op/s] or [+5.213%; +5.492%]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrations Involves tracing integrations tracing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants