Skip to content

[BUG]: Compilation error with nginx 1.26.3 nginx-datadog 1.6.1 #217

Closed
@Simoouqas

Description

@Simoouqas

Module Version(s)

1.6.1

Bug Report

After i posted this issue and it was resolved with this commit 629830997934c2fded64271a30d1fcc5ee174bec
now i bumped nginx-datadog to 1.6.1 which includes the fix commit but now i have this error

In file included from /tmp/nginx-datadog/src/common/directives.cpp:1:
/tmp/nginx-datadog/src/common/directives.h:17:24: error: 'datadog::common::ngx_conf_post_file_exists' defined but not used [-Werror=unused-variable]
   17 | static ngx_conf_post_t ngx_conf_post_file_exists = {check_file_exists};
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
gmake[3]: *** [CMakeFiles/ngx_http_datadog_objs.dir/build.make:90: CMakeFiles/ngx_http_datadog_objs.dir/src/common/directives.cpp.o] Error 1
gmake[3]: *** Waiting for unfinished jobs....
gmake[3]: Leaving directory '/tmp/nginx-datadog/.build'
gmake[2]: Leaving directory '/tmp/nginx-datadog/.build'
gmake[2]: *** [CMakeFiles/Makefile2:1350: CMakeFiles/ngx_http_datadog_objs.dir/all] Error 2
gmake[1]: *** [Makefile:146: all] Error 2
gmake[1]: Leaving directory '/tmp/nginx-datadog/.build'

make: *** [Makefile:24: build] Error 2

i tried to follow up and debug to find which commit introduces the problem and it this one 45ce45e2cc0ea63a88b204a2d2155983bc7df679
introduced to this PR

nothing changed from our end. everything is still the same as declared in the first issue, i figured this might be a small fix, if not i can provide you will all the details you need

Reproduction Code

No response

Error Logs

No response

Operating System

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions