Merge pull request #136 from DataObjects-NET/6.0-test-fixes

Revision of tests that fail

Author: alex-kulakov

ChangeLog/6.0.6_dev.txt

@@ -21,9 +21,25 @@
 [main] Obsolete ServerFeatures property is removed
 [main] Fixed possible cases of broken serialization due to comparers
 [main] Fixed rare cases of insert wrong data into some table columns for SingleTable hierarchies
-[sqlserver] Fixed incorrect DateTimeOffset.Date part extraction
-[sqlserver] Improved translation of DateTimeOffset.LocalDateTime and DateTimeOffset.TimeOfDay parts extraction
+[main] Exception message about unsupported by storage type became more informative
+[firebird] Another error code that means unique contraint violation is treated correctly
+[firebird] Improved formatting for Float and Double constants within queries
+[firebird] Improved work with DateTime query parameters
+[firebird] Fixed columns' default value extraction
+[mysql] Another error code that means unique contraint violation is treated correctly
+[mysql] Fixed DateTime.DayOfWeek translation
+[oracle] Changed NULLs ordering settings. Now order is the same as in .NET
+[oracle] Improved resolution of TimeSpan literal values on translation
+[oracle] Starting from v11 schema names don't have to be in upper-case as storage allowes names in any case
+[oracle] Improved translation of Math.Ceiling(), Math.Truncate() and Math.Floor()
+[oracle] Fixed byte array fields comparison translation e.g. in Where statements
+[oracle] Improved translation of DateTimeOffset's LocalDateTime, ToLocalTime() and ToUniversalTime() members
 [postgresql] Improved performance of First(), FirstOrDefault() being subqueries
-[postgresql] Improved translation of Math.Ceiling(), Math.Truncate() and Math.Floor()
+[postgresql] Improved translation of Math.Ceiling(), Math.Truncate() and Math.Floor() methods
+[postgresql] Skip Commit/Rollback operations for already completed transaction to prevent exception overlaping
+[sqlite] Fixed some foreign key extraction issues
+[sqlite] Improved work with DateTime query parameters
+[sqlserver] Fixed incorrect DateTimeOffset.Date part extraction
+[sqlserver] Improved translation of DateTimeOffset's LocalDateTime and TimeOfDay members
 [reprocessing] ExecuteActionStrategy.Execute doesn't get external session though Session.Current at all
-[reprocessing] Introduced DomainExtension.WithSession and IExecuteConfiguration WithSession methods to pass external session
+[reprocessing] Introduced DomainExtension.WithSession() and IExecuteConfiguration.WithSession() methods to pass external session

Extensions/TestCommon/CommonModelTest.cs

@@ -1,68 +1,35 @@
 // Copyright (C) 2019-2020 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
-
-using System.Collections.Generic;
 using NUnit.Framework;
 using TestCommon.Model;
-using Xtensive.Core;
-using Xtensive.Orm;
 using Xtensive.Orm.Configuration;
+using Xtensive.Orm.Tests;
 
 namespace TestCommon
 {
   [TestFixture]
-  public abstract class CommonModelTest
+  public abstract class CommonModelTest : AutoBuildTest
   {
-    private List<Session> notDisposed;
-
-    protected Domain Domain { get; private set; }
+    private bool justBuilt = true;
 
     [SetUp]
     public virtual void SetUp()
     {
-      CheckRequirements();
-      var config = BuildConfiguration();
-      Domain = BuildDomain(config);
-      notDisposed = new List<Session>();
-      Domain.SessionOpen += (sender, args) => {
-        notDisposed.Add(args.Session);
-        args.Session.Events.Disposing += (o, eventArgs) => {
-          lock (notDisposed) {
-            notDisposed.Remove(args.Session);
-          }
-        };
-      };
-      PopulateData();
+      if (justBuilt) {
+        justBuilt = false;
+      }
+      else {
+        RebuildDomain();
+      }
     }
 
-    [TearDown]
-    public virtual void TearDown()
-    {
-      if (notDisposed!=null)
-        Assert.That(notDisposed, Is.Empty);
-      Assert.That(SessionScope.CurrentSession, Is.Null);
-      Domain.DisposeSafely();
-    }
 
-    protected virtual DomainConfiguration BuildConfiguration()
+    protected override DomainConfiguration BuildConfiguration()
     {
-      var configuration = DomainConfigurationFactory.Create();
+      var configuration = base.BuildConfiguration();
       configuration.Types.Register(typeof (Bar).Assembly);
       return configuration;
     }
-
-    protected virtual Domain BuildDomain(DomainConfiguration configuration)
-    {
-      return Domain.Build(configuration);
-    }
-
-    protected virtual void PopulateData()
-    {
-    }
-
-    protected virtual void CheckRequirements()
-    {
-    }
   }
 }

Extensions/TestCommon/DomainConfigurationFactory.cs

@@ -1,5 +1,6 @@
-using System;
+using System;
 using NUnit.Framework;
+using Xtensive.Orm.Tests;
 
 namespace TestCommon.Tests
 {

Extensions/TestCommon/HasAccessToConfigurationTest.cs

@@ -1,18 +1,18 @@
-using NUnit.Framework;
+using NUnit.Framework;
 using TestCommon;
 using TestCommon.Model;
 using Xtensive.Orm.Configuration;
 
 namespace Xtensive.Orm.BulkOperations.Tests
 {
   [TestFixture]
-  public abstract class AutoBuildTest : CommonModelTest
+  public abstract class BulkOperationBaseTest : CommonModelTest
   {
     protected override DomainConfiguration BuildConfiguration()
     {
       var configuration = base.BuildConfiguration();
-      configuration.Types.Register(typeof (IUpdatable<>).Assembly);
-      configuration.Types.Register(typeof (AutoBuildTest).Assembly);
+      configuration.Types.Register(typeof(IUpdatable<>).Assembly);
+      configuration.Types.Register(typeof(BulkOperationBaseTest).Assembly);
       return configuration;
     }
   }

Extensions/TestCommon/TestConfiguration.cs

@@ -1,4 +1,4 @@
-// Copyright (C) 2020 Xtensive LLC.
+// Copyright (C) 2020-2021 Xtensive LLC.
 // This code is distributed under MIT license terms.
 // See the License.txt file in the project root for more information.
 
@@ -29,7 +29,7 @@ public TagType(Session session, long id)
 
 namespace Xtensive.Orm.BulkOperations.Tests
 {
-  public class ContainsTest : AutoBuildTest
+  public class ContainsTest : BulkOperationBaseTest
   {
     private long[] tagIds;
 
@@ -45,8 +45,10 @@ protected override void PopulateData()
       tagIds = Enumerable.Range(0, 100).Select(i => (long) i).ToArray();
       using (var session = Domain.OpenSession())
       using (var transaction = session.OpenTransaction()) {
-        foreach (var id in tagIds.Concat(Enumerable.Repeat(1000, 1).Select(i => (long) i)))
-          new TagType(session, id) { ProjectedValueAdjustment = -1 };
+        foreach (var id in tagIds.Concat(Enumerable.Repeat(1000, 1).Select(i => (long) i))) {
+          _ = new TagType(session, id) { ProjectedValueAdjustment = -1 };
+        }
+
         transaction.Complete();
       }
     }
@@ -86,7 +88,7 @@ public void Test3()
     {
       using (var session = Domain.OpenSession())
       using (var tx = session.OpenTransaction()) {
-        Assert.Throws<NotSupportedException>(() => session.Query.All<TagType>()
+        _ = Assert.Throws<NotSupportedException>(() => session.Query.All<TagType>()
           .Where(t => t.Id.In(IncludeAlgorithm.TemporaryTable, tagIds))
           .Set(t => t.ProjectedValueAdjustment, 2)
           .Update());

Extensions/TestCommon/Tests/TestConfigurationTest.cs

@@ -8,7 +8,7 @@ public static class Extensions
   {
     public static void AssertCommandCount(this Session session, IResolveConstraint expression, Action action)
     {
-      int count = 0;
+      var count = 0;
       session.Events.DbCommandExecuting += (sender, args) => count++;
       action();
       Assert.That(count, expression);

Extensions/Xtensive.Orm.BulkOperations.Tests/AutoBuildTest.cs renamed to Extensions/Xtensive.Orm.BulkOperations.Tests/BulkOperationBaseTest.cs

@@ -44,19 +44,19 @@ public abstract class AbstractBaseForServiceMaterial : Entity
 
 namespace Xtensive.Orm.BulkOperations.Tests.Issues
 {
-  public class IssueJira0560_ChangeFieldWhichDefinedInAncestorClassBug : AutoBuildTest
+  public class IssueJira0560_ChangeFieldWhichDefinedInAncestorClassBug : BulkOperationBaseTest
   {
     [Test]
     public void UpdateTest()
     {
-      List<int> keys = new List<int>();
+      var keys = new List<int>();
       using (var session = Domain.OpenSession())
       using (session.Activate())
       using (var transaction = session.OpenTransaction()) {
-        for (int i = 0; i < 10; i++) {
+        for (var i = 0; i < 10; i++) {
           var owner = new PreservedService();
           keys.Add(owner.Id);
-          new ServiceMaterial { Active = false, Owner = owner };
+          _ = new ServiceMaterial { Active = false, Owner = owner };
         }
         transaction.Complete();
       }