Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inefficiency exists in static esp_err_t _write_top_nibble(const i2c_lcd1602_info_t * i2c_lcd1602_info, uint8_t data) #4

Open
FrancoisLegerBe opened this issue May 7, 2022 · 0 comments

Comments

@FrancoisLegerBe
Copy link

FrancoisLegerBe commented May 7, 2022

Some (most?) LCD1602 uses a ST7066U front end IC.
When using this IC, the storage of the data from the I2C interface occurs on the up to low transition of the EN signal.
Using three I2C transmissions is useless, as the EN low to UP transition does not do anything, therefore the _write_to_expander call before the _strobe_enable can be removed in the _write_top_nibble when using such setup. This will reduce the I2C communication load by one third.

Note: the EN signal is controlled by the FLAG_ENABLE value.

lukecyca added a commit to lukecyca/esp32-i2c-lcd1602 that referenced this issue Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant