probe: cmsis-dap: hidapi backend: retrieve actual report sizes (pyocd#1828)

- Windows: use HidD_GetPreparsedData and HidP_GetCaps
- macOS: use IOHIDDeviceGetProperty

Author: DavidLesnjak

pyocd/probe/pydapaccess/interface/hidapi_backend.py

@@ -20,8 +20,6 @@
 import platform
 import threading
 import queue
-import struct
-import array
 from typing import Optional, Tuple
 
 from .interface import Interface
@@ -177,13 +175,11 @@ def set_packet_count(self, count):
         self.packet_count = count
 
     def open(self):
-        probe_id = self.serial_number or f"VID={self.vid:#06x}:PID={self.pid:#06x}"
-
         self.report_in_size, self.report_out_size = self._get_hid_report_sizes()
 
         if self.report_in_size is None:
             # Fallback: set report size to 64 bytes
-            LOG.warning("Could not determine IN report size for probe %s, defaulting to 64 bytes", probe_id)
+            LOG.warning("Could not determine IN report size for probe %s, defaulting to 64 bytes", to_str_safe(self.serial_number))
             self.report_in_size = 64
 
         if self.report_out_size is None:
@@ -242,8 +238,9 @@ def _get_hid_report_sizes_windows(self) -> Tuple[Optional[int], Optional[int]]:
                 HIDP_STATUS_SUCCESS = 0x00110000
                 if hid_dll.HidP_GetCaps(preparsed_data, ctypes.byref(caps)) == HIDP_STATUS_SUCCESS:
                     # The lengths include the report ID byte, which we don't use in the packet size.
-                    # However, the packet size should match the report size.
-                    return caps.InputReportByteLength, caps.OutputReportByteLength
+                    InReportSz = caps.InputReportByteLength - 1 if caps.InputReportByteLength > 0 else None
+                    OutReportSz = caps.OutputReportByteLength - 1 if caps.OutputReportByteLength > 0 else None
+                    return InReportSz, OutReportSz
                 else:
                     LOG.debug("HidP_GetCaps failed.")
                     return None, None
@@ -254,8 +251,6 @@ def _get_hid_report_sizes_windows(self) -> Tuple[Optional[int], Optional[int]]:
         return None, None
 
     def _get_hid_report_sizes_macos(self) -> Tuple[Optional[int], Optional[int]]:
-        # The hid.device object from hidapi is what we need.
-        # The underlying object is an IOHIDDeviceRef, which is a void*
         hid_device_ref = ctypes.c_void_p(self.device.dev)
         input_size = None
         output_size = None