Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix gitpython version and remove jsonlines #3964

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Fix gitpython version and remove jsonlines #3964

merged 2 commits into from
Mar 3, 2021

Conversation

damiencarol
Copy link
Contributor

@damiencarol damiencarol commented Mar 1, 2021 •
edited
Loading

Fix 2 dependencies problems:

  1. gitpython don't use a pinned version, switching to a pinned one

    django-DefectDojo/requirements.txt

    Line 55 in 920503f

    gitpython>=2.1.13
  2. remove useless dependency jsonlines

    django-DefectDojo/requirements.txt

    Line 62 in 920503f

    jsonlines==2.0.0 # requred by yarn audit parser

Regarding the 1)

Relevant issue upstream gitpython-developers/GitPython#983

 File "/usr/local/lib/python3.6/site-packages/git/compat.py", line 16, in <module>
    from gitdb.utils.compat import (
ModuleNotFoundError: No module named 'gitdb.utils.compat'

@damiencarol damiencarol requested review from a team March 1, 2021 17:32
@damiencarol damiencarol added this to the 1.14.0 milestone Mar 1, 2021
@damiencarol damiencarol marked this pull request as draft March 1, 2021 17:37
@damiencarol
Copy link
Contributor Author

@valentijnscholten this is an interesting issue

@damiencarol damiencarol marked this pull request as ready for review March 1, 2021 21:11
@madchap madchap merged commit 1b97210 into DefectDojo:dev Mar 3, 2021
@damiencarol damiencarol deleted the fix_unpinned_versions branch March 4, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentijnscholten valentijnscholten valentijnscholten approved these changes

@madchap madchap madchap approved these changes

Assignees
No one assigned
Labels
easy-review maintenance
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@damiencarol @valentijnscholten @madchap