Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit 890c778

Browse files
jablkojablko
committed
Update snapshots
1 parent 0a29b2f commit 890c778

File tree

104 files changed

+808
-150
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

104 files changed

+808
-150
lines changed

‎src/_tests/fixtures/38979/derived.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -299,12 +299,16 @@
299299
{
300300
"path": "types/es-abstract/tsconfig.json",
301301
"kind": "package-meta",
302-
"suspect": "couldn't fetch contents"
302+
"suspect": {
303+
"body": "couldn't fetch contents"
304+
}
303305
},
304306
{
305307
"path": "types/es-abstract/tslint.json",
306308
"kind": "package-meta",
307-
"suspect": "couldn't fetch contents"
309+
"suspect": {
310+
"body": "couldn't fetch contents"
311+
}
308312
}
309313
],
310314
"owners": [

‎src/_tests/fixtures/38979/mutations.json

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
"variables": {
3737
"input": {
3838
"id": "MDEyOklzc3VlQ29tbWVudDYyNzA5NzAxMg==",
39-
"body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n - Config files to check:\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
39+
"body": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc), [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
4040
}
4141
}
4242
},
@@ -66,5 +66,35 @@
6666
"body": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)\n<!--typescript_bot_Unreviewed:done-->"
6767
}
6868
}
69+
},
70+
{
71+
"query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }",
72+
"variables": {
73+
"input": {
74+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0",
75+
"path": "types/es-abstract/tsconfig.json",
76+
"body": "couldn't fetch contents"
77+
}
78+
}
79+
},
80+
{
81+
"query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }",
82+
"variables": {
83+
"input": {
84+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0",
85+
"path": "types/es-abstract/tslint.json",
86+
"body": "couldn't fetch contents"
87+
}
88+
}
89+
},
90+
{
91+
"query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }",
92+
"variables": {
93+
"input": {
94+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0MzI1ODk5Njc0",
95+
"body": "@ExE-Boss I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!",
96+
"event": "COMMENT"
97+
}
98+
}
6999
}
70100
]

‎src/_tests/fixtures/38979/result.json

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"responseComments": [
1111
{
1212
"tag": "welcome",
13-
"status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n - Config files to check:\n - [`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc): couldn't fetch contents\n - [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6): couldn't fetch contents\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..."
13+
"status": "@ExE-Boss Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `es-abstract` [on npm](https://www.npmjs.com/package/es-abstract), [on unpkg](https://unpkg.com/browse/es-abstract@latest/)\n\n## Code Reviews\n\nBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ A DT maintainer needs to approve changes which affect module config files ([`es-abstract/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-abcd3ac52c6c4c77c7fa2a0e5bc09313ca1cbfd335f929838b0a4e3a607774cc), [`es-abstract/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/38979/files/222334139e52fc16369464cfb5dc95c82f71192f#diff-1eda518cd7bfbcd5fa96a7f844b631954cbc9db9ff168fc3731abb874369a4f6))\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n## Inactive\n\nThis PR has been inactive for 129 days — it is *still* unreviewed!\n\n----------------------\n... diagnostics scrubbed ..."
1414
},
1515
{
1616
"tag": "pinging-reviewers",
@@ -25,7 +25,16 @@
2525
"status": "It has been more than two weeks and this PR still has no reviews.\n\nI'll bump it to the DT maintainer queue. Thank you for your patience, @ExE-Boss.\n\n(Ping @RReverser.)"
2626
}
2727
],
28-
"suggestions": [],
28+
"explanations": [
29+
{
30+
"path": "types/es-abstract/tsconfig.json",
31+
"body": "couldn't fetch contents"
32+
},
33+
{
34+
"path": "types/es-abstract/tslint.json",
35+
"body": "couldn't fetch contents"
36+
}
37+
],
2938
"shouldClose": false,
3039
"shouldMerge": false,
3140
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43136/result.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
"status": "@RReverser Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
1919
}
2020
],
21-
"suggestions": [],
21+
"explanations": [],
2222
"shouldClose": false,
2323
"shouldMerge": false,
2424
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43144/result.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"status": "@jeffreymeng Everything looks good here. Great job! I am ready to merge this PR (at f1f5c4b) on your behalf.\n\nIf you'd like that to happen, please post a comment saying:\n\n> Ready to merge\n\nand I'll merge this PR almost instantly. Thanks for helping out! :heart:\n\n(@pocesar: you can do this too.)"
1616
}
1717
],
18-
"suggestions": [],
18+
"explanations": [],
1919
"shouldClose": false,
2020
"shouldMerge": false,
2121
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43151/derived.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,16 @@
2727
{
2828
"path": "types/gaze/tsconfig.json",
2929
"kind": "package-meta",
30-
"suspect": "couldn't fetch contents"
30+
"suspect": {
31+
"body": "couldn't fetch contents"
32+
}
3133
},
3234
{
3335
"path": "types/gaze/tslint.json",
3436
"kind": "package-meta",
35-
"suspect": "couldn't fetch contents"
37+
"suspect": {
38+
"body": "couldn't fetch contents"
39+
}
3640
}
3741
],
3842
"owners": [],

‎src/_tests/fixtures/43151/mutations.json

Lines changed: 31 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"variables": {
3636
"input": {
3737
"subjectId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5",
38-
"body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n - Config files to check:\n - [`gaze/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-75a1852febb3e488c3c078da451a82e5a8609bd59ef44ddd0656bbb96150c1a0): couldn't fetch contents\n - [`gaze/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-a0512397f95f6b7994f9713c8ceb6144061e7cf0d81618a2a9a90cceda075f80): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
38+
"body": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ...\n<!--typescript_bot_welcome-->"
3939
}
4040
}
4141
},
@@ -47,5 +47,35 @@
4747
"body": "🔔 @adamzerella — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)\n<!--typescript_bot_pinging-reviewers-others-->"
4848
}
4949
}
50+
},
51+
{
52+
"query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }",
53+
"variables": {
54+
"input": {
55+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5",
56+
"path": "types/gaze/tsconfig.json",
57+
"body": "couldn't fetch contents"
58+
}
59+
}
60+
},
61+
{
62+
"query": "mutation($input: AddPullRequestReviewThreadInput!) { addPullRequestReviewThread(input: $input) { clientMutationId } }",
63+
"variables": {
64+
"input": {
65+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5",
66+
"path": "types/gaze/tslint.json",
67+
"body": "couldn't fetch contents"
68+
}
69+
}
70+
},
71+
{
72+
"query": "mutation($input: SubmitPullRequestReviewInput!) { submitPullRequestReview(input: $input) { clientMutationId } }",
73+
"variables": {
74+
"input": {
75+
"pullRequestId": "MDExOlB1bGxSZXF1ZXN0Mzg4Njk0NDU5",
76+
"body": "@adamzerella I noticed these differences from the required form. If you can revise your changes to avoid them, so much the better! Otherwise please reply with explanations why they're needed and a maintainer will take a look. Thanks!",
77+
"event": "COMMENT"
78+
}
79+
}
5080
}
5181
]

‎src/_tests/fixtures/43151/result.json

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,23 @@
88
"responseComments": [
99
{
1010
"tag": "welcome",
11-
"status": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n - Config files to check:\n - [`gaze/tsconfig.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-75a1852febb3e488c3c078da451a82e5a8609bd59ef44ddd0656bbb96150c1a0): couldn't fetch contents\n - [`gaze/tslint.json`](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files/bb6d3150b485cd203d265e06ca910262256e523e#diff-a0512397f95f6b7994f9713c8ceb6144061e7cf0d81618a2a9a90cceda075f80): couldn't fetch contents\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
11+
"status": "@adamzerella Thank you for submitting this PR!\n\n***This is a live comment which I will keep updated.***\n\n## 1 package in this PR\n\n* `gaze` (*new!*) [on npm](https://www.npmjs.com/package/gaze), [on unpkg](https://unpkg.com/browse/gaze@latest/)\n - 1 added owner: ✎@adamzerella\n\n## Code Reviews\n\nThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged.\n\n## Status\n\n * ✅ No merge conflicts\n * ✅ Continuous integration tests have passed\n * ❌ Only a DT maintainer can approve changes when there are new packages added\n\nOnce every item on this list is checked, I'll ask you for permission to merge and publish the changes.\n\n----------------------\n... diagnostics scrubbed ..."
1212
},
1313
{
1414
"tag": "pinging-reviewers-others",
1515
"status": "🔔 @adamzerella — you're the only owner, but it would still be good if you find someone to [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43151/files) in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)"
1616
}
1717
],
18-
"suggestions": [],
18+
"explanations": [
19+
{
20+
"path": "types/gaze/tsconfig.json",
21+
"body": "couldn't fetch contents"
22+
},
23+
{
24+
"path": "types/gaze/tslint.json",
25+
"body": "couldn't fetch contents"
26+
}
27+
],
1928
"shouldClose": false,
2029
"shouldMerge": false,
2130
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43160/result.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"status": "@rikkertkoppes The CI build failed! Please [review the logs for more information](https://github.com/DefinitelyTyped/DefinitelyTyped/commit/22c73c88cc9c09efd4c2998ec360607dd4c36c2e/checks?check_suite_id=731664306).\r\n\r\nOnce you've pushed the fixes, the build will automatically re-run. Thanks!"
2121
}
2222
],
23-
"suggestions": [],
23+
"explanations": [],
2424
"shouldClose": false,
2525
"shouldMerge": false,
2626
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43175/result.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
"status": "@couven92 Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?"
2424
}
2525
],
26-
"suggestions": [],
26+
"explanations": [],
2727
"shouldClose": false,
2828
"shouldMerge": false,
2929
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43235/result.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
"status": "🔔 @Esri @bsvensson — please [review this PR](https://github.com/DefinitelyTyped/DefinitelyTyped/pull/43235/files) in the next few days. Be sure to explicitly select **`Approve`** or **`Request Changes`** in the GitHub UI so I know what's going on."
1313
}
1414
],
15-
"suggestions": [],
15+
"explanations": [],
1616
"shouldClose": false,
1717
"shouldMerge": false,
1818
"shouldUpdateLabels": true,

‎src/_tests/fixtures/43314/derived.json

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,16 @@
2727
{
2828
"path": "types/carbon__icon-helpers/tsconfig.json",
2929
"kind": "package-meta",
30-
"suspect": "couldn't fetch contents"
30+
"suspect": {
31+
"body": "couldn't fetch contents"
32+
}
3133
},
3234
{
3335
"path": "types/carbon__icon-helpers/tslint.json",
3436
"kind": "package-meta",
35-
"suspect": "couldn't fetch contents"
37+
"suspect": {
38+
"body": "couldn't fetch contents"
39+
}
3640
}
3741
],
3842
"owners": [],

0 commit comments

Comments
 (0)