Skip to content
This repository was archived by the owner on Jul 1, 2024. It is now read-only.

Commit e672b8a

Browse files
committed
Apply suggestions from code review
1 parent b52c4ed commit e672b8a

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/pr-info.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -419,18 +419,12 @@ function makeJsonCheckerFromCore(requiredForm: any, ignoredKeys: string[]) {
419419
const newDiff = diffFromReq(contents);
420420
if (typeof newDiff === "string") return newDiff;
421421
if (newDiff.length === 0) return undefined;
422-
if (!oldText) return `not the required form
423-
\`\`\`JSON
424-
${JSON.stringify(newDiff)}
425-
\`\`\``;
422+
if (!oldText) return `not the required form \`${JSON.stringify(newDiff)}\``;
426423
const oldDiff = diffFromReq(oldText);
427424
if (typeof oldDiff === "string") return oldDiff;
428425
const notRemove = jsonDiff.compare(oldDiff, newDiff).filter(({ op }) => op !== "remove");
429426
if (notRemove.length === 0) return undefined;
430-
return `not the required form and not moving towards it
431-
\`\`\`JSON
432-
${JSON.stringify(notRemove.map(({ path }) => newDiff[Number(path.slice(1))]))}
433-
\`\`\``;
427+
return `not the required form and not moving towards it \`${JSON.stringify(notRemove.map(({ path }) => newDiff[Number(path.slice(1))]))}\``;
434428
};
435429
}
436430

0 commit comments

Comments
 (0)