Replace PackageCompiler with juliac #2460
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #2440.
It replaces PackageCompiler with the juliac script to compile libribasim.
Note that it uses
--trimming=nobecause we don't support that yet.Advantages
Disadvantages
TODO
I'm closing this directly since I think it is better to stick to PackageCompiler for now, hopefully it will build on or catch up to juliac in the future, then we can use that.
Taking
libribasim.jlout of Ribasim is something that might be interesting anyway. Also I assume that in time we can removejulia_initlike done in 48a5605.