Skip to content

Improving code efficiency in computing subsurface flow routing #1046

Description

@AquaPore

Feature type

Changing existing functionality

Improvement Description

Dear Wflow colleagues,

I am putting forward that the efficiency of subsurface flow can be improved.

The saturated hydraulic conductivity varies with depth depending on the models we select such as "layered", "exponential", "exponential_constant", "layered_exponential".

From my understanding, independently of the selected model we can compute for every cell in the profile the horizontal saturated hydraulic conductivity kh_profile[j] per cell as follows:

$Kh\_profile[i]=horizontal\_to\_vertical\_hydraulic\_Conductivity\_Ratio . Kv\_profile[i]$

If this is the case, then why in for example the lateral_subsurface_flow.jl do we go to into the trouble of recomputing Kv_profile to compute Kh_profile by using different structures for example KhExponential, KhExponentialConstant, KhLayered?

With kindness,
Joseph A.P. Pollacco

Implementation Description

No response

Additional Context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions