Add filterAttrs builtin

Author: not-ronjinger

src/libexpr-tests/primops.cc

@@ -320,6 +320,31 @@ TEST_F(PrimOpTest, mapAttrs)
     ASSERT_THAT(*b->value, IsIntEq(20));
 }
 
+TEST_F(PrimOpTest, filterAttrs)
+{
+    auto v = eval("builtins.filterAttrs (name: value: value > 5) { a = 3; b = 10; c = 7; }");
+    ASSERT_THAT(v, IsAttrsOfSize(2));
+
+    auto a = v.attrs()->get(createSymbol("a"));
+    ASSERT_EQ(a, nullptr);
+
+    auto b = v.attrs()->get(createSymbol("b"));
+    ASSERT_NE(b, nullptr);
+    state.forceValue(*b->value, noPos);
+    ASSERT_THAT(*b->value, IsIntEq(10));
+
+    auto c = v.attrs()->get(createSymbol("c"));
+    ASSERT_NE(c, nullptr);
+    state.forceValue(*c->value, noPos);
+    ASSERT_THAT(*c->value, IsIntEq(7));
+}
+
+TEST_F(PrimOpTest, filterAttrsEmpty)
+{
+    auto v = eval("builtins.filterAttrs (name: value: false) { a = 1; b = 2; }");
+    ASSERT_THAT(v, IsAttrsOfSize(0));
+}
+
 TEST_F(PrimOpTest, isList)
 {
     auto v = eval("builtins.isList []");

src/libexpr/primops.cc

@@ -3505,6 +3505,50 @@ static RegisterPrimOp primop_mapAttrs({
     .fun = prim_mapAttrs,
 });
 
+static void prim_filterAttrs(EvalState & state, const PosIdx pos, Value ** args, Value & v)
+{
+    state.forceAttrs(*args[1], pos, "while evaluating the second argument passed to builtins.filterAttrs");
+
+    if (args[1]->attrs()->empty()) {
+        v = *args[1];
+        return;
+    }
+
+    state.forceFunction(*args[0], pos, "while evaluating the first argument passed to builtins.filterAttrs");
+
+    auto attrs = state.buildBindings(args[1]->attrs()->size());
+
+    for (auto & i : *args[1]->attrs()) {
+        Value * vName = Value::toPtr(state.symbols[i.name]);
+        Value * vFun2 = state.allocValue();
+        vFun2->mkApp(args[0], vName);
+        Value res;
+        state.callFunction(*vFun2, *i.value, res, noPos);
+        if (state.forceBool(
+                res, pos, "while evaluating the return value of the filtering function passed to builtins.filterAttrs"))
+            attrs.insert(i.name, i.value);
+    }
+
+    v.mkAttrs(attrs.alreadySorted());
+}
+
+static RegisterPrimOp primop_filterAttrs({
+    .name = "__filterAttrs",
+    .args = {"f", "attrset"},
+    .doc = R"(
+      Return an attribute set consisting of the attributes in *attrset* for which
+      the function *f* returns `true`. The function *f* is called with two arguments:
+      the name of the attribute and the value of the attribute. For example,
+
+      ```nix
+      builtins.filterAttrs (name: value: name == "foo") { foo = 1; bar = 2; }
+      ```
+
+      evaluates to `{ foo = 1; }`.
+    )",
+    .fun = prim_filterAttrs,
+});
+
 static void prim_zipAttrsWith(EvalState & state, const PosIdx pos, Value ** args, Value & v)
 {
     // we will first count how many values are present for each given key.