Skip to content

Commit ad6d520

Browse files
committed
fix: bump rod as it was breaking login flow
1 parent 04c85dc commit ad6d520

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

go.mod

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ require (
77
github.com/mitchellh/go-ps v1.0.0
88
github.com/pkg/errors v0.9.1
99
github.com/spf13/cobra v1.3.0
10-
github.com/spf13/viper v1.10.1
10+
// github.com/spf13/viper v1.10.1
1111
github.com/zalando/go-keyring v0.2.1
1212
)
1313

@@ -26,7 +26,7 @@ require (
2626

2727
require (
2828
github.com/fsnotify/fsnotify v1.5.1 // indirect
29-
github.com/go-rod/rod v0.103.0
29+
github.com/go-rod/rod v0.104.2
3030
github.com/hashicorp/hcl v1.0.0 // indirect
3131
github.com/inconshreveable/mousetrap v1.0.0 // indirect
3232
github.com/jmespath/go-jmespath v0.4.0 // indirect

go.sum

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,8 @@ github.com/go-openapi/swag v0.19.2/go.mod h1:POnQmlKehdgb5mhVOsnJFsivZCEZ/vjK9gh
202202
github.com/go-openapi/swag v0.19.5/go.mod h1:POnQmlKehdgb5mhVOsnJFsivZCEZ/vjK9gh66Z9tfKk=
203203
github.com/go-rod/rod v0.103.0 h1:pJPhdZPdbY75iyWMNSqiTYQnHHfuGUj0QY6WJ8B7ot4=
204204
github.com/go-rod/rod v0.103.0/go.mod h1:RXSLAlPodTFOmZnwaAQJIcOJ1i835r0uuTGPLO09t/M=
205+
github.com/go-rod/rod v0.104.2 h1:L2r/K5Dp2YoJrPTixCXB1++vFtJSWOrNvD7RvXK1Mj4=
206+
github.com/go-rod/rod v0.104.2/go.mod h1:SVRIBdiq0sXXDdQxISmWuY8g1kLIUT+Pgk4VZSbOM1s=
205207
github.com/go-sql-driver/mysql v1.4.0/go.mod h1:zAC/RDZ24gD3HViQzih4MyKcchzm+sOG5ZlKdlhCg5w=
206208
github.com/go-stack/stack v1.8.0/go.mod h1:v0f6uXyyMGvRgIKkXu+yp6POWl0qKG85gN/melR3HDY=
207209
github.com/godbus/dbus/v5 v5.0.4/go.mod h1:xhWf0FNVPg57R7Z0UbKHbJfkEywrmjJnf7w5xrFpKfA=

internal/auth/saml.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ func GetSamlCreds(conf config.SamlConfig) {
1717

1818
secretStore := util.NewSecretStore(conf.BaseConfig.Role)
1919
var awsCreds *util.AWSCredentials
20-
20+
var webBrowser *web.Web
2121
var err error
2222

2323
// Try to reuse stored credential in secret
@@ -26,9 +26,9 @@ func GetSamlCreds(conf config.SamlConfig) {
2626
}
2727

2828
if !util.IsValid(awsCreds) || err != nil {
29-
web := web.New()
29+
webBrowser = web.New()
3030

31-
t, err := web.GetSamlLogin(conf)
31+
t, err := webBrowser.GetSamlLogin(conf)
3232
if err != nil {
3333
util.Writeln("Err: %v", err)
3434
}

0 commit comments

Comments
 (0)