fix: ensure cli exits after every run cleanly

Author: dnitsch

Makefile

@@ -1,6 +1,6 @@
 OWNER := dnitsch
 NAME := aws-cli-auth
-VERSION := v0.7.8
+VERSION := v0.8.0
 REVISION := $(shell git rev-parse --short HEAD)
 
 LDFLAGS := -ldflags="-s -w -X \"github.com/dnitsch/aws-cli-auth/cmd.Version=$(VERSION)\" -X \"github.com/dnitsch/aws-cli-auth/cmd.Revision=$(REVISION)\" -extldflags -static"

cmd/clear.go

@@ -39,4 +39,6 @@ func clear(cmd *cobra.Command, args []string) {
 	if err := os.Remove(util.ConfigIniFile()); err != nil {
 		util.Exit(err)
 	}
+
+	util.CleanExit()
 }

cmd/saml.go

@@ -3,6 +3,7 @@ package cmd
 import (
 	"github.com/dnitsch/aws-cli-auth/internal/auth"
 	"github.com/dnitsch/aws-cli-auth/internal/config"
+	"github.com/dnitsch/aws-cli-auth/internal/util"
 	"github.com/spf13/cobra"
 )
 
@@ -38,5 +39,5 @@ func getSaml(cmd *cobra.Command, args []string) {
 	}
 
 	auth.GetSamlCreds(conf)
-
+	util.CleanExit()
 }

cmd/version.go

@@ -4,6 +4,7 @@ import (
 	"fmt"
 
 	"github.com/dnitsch/aws-cli-auth/internal/config"
+	"github.com/dnitsch/aws-cli-auth/internal/util"
 	"github.com/spf13/cobra"
 )
 
@@ -22,5 +23,6 @@ var versionCmd = &cobra.Command{
 	Long:  `Version and Revision number of the installed CLI`,
 	Run: func(cmd *cobra.Command, args []string) {
 		fmt.Printf("Version: %s\nRevision: %s\n", Version, Revision)
+		util.CleanExit()
 	},
 }

internal/util/helper.go

@@ -158,3 +158,8 @@ func GetAllIniSections() ([]string, error) {
 	}
 	return sections, nil
 }
+
+// CleanExit signals 0 exit code and should clean up any current process
+func CleanExit() {
+	os.Exit(0)
+}