Editing root group devices isn't available as an admin

[noa-cohen-unity]

What is the issue or idea you have?
I work with stf local on my local computer.
I added devices by locally wire connecting them to my computer.
When logged in as an admin, i created a new group and wanted to allocate the devices there, but the buttons for doing it from the UI weren't available, even though im an admin and in the 'root' privilege group 'Common'.
Looks like a bug.
Does it only happen on a specific device? Please run adb devices -l and paste the corresponding row.
no
Please provide the steps to reproduce the issue.

1. Open stf local url after running rethinkDB and stf local command
2. login as an admin
3. Go to 'settings'
4. Go to 'Groups' tab
5. Create another group from the UI
6. Try to remove the devices from the 'Common' group

What is the expected behavior?
Expected: You can remove devices form 'Common' group into the 'Available devices' section
Actual: the btn is disabled

Do you see errors or warnings in the stf local output? If so, please paste them or the full log here.
no

Please run stf doctor and paste the output here.
2025-01-19T12:23:55.129Z INF/cli:doctor 51171 [] OS Arch: arm64
2025-01-19T12:23:55.130Z INF/cli:doctor 51171 [] OS Platform: darwin
2025-01-19T12:23:55.130Z INF/cli:doctor 51171 [] OS Platform: 24.1.0
2025-01-19T12:23:55.130Z INF/cli:doctor 51171 [] Using Node 18.20.5
2025-01-19T12:23:55.139Z INF/cli:doctor 51171 [] Using ZeroMQ 4.2.2
2025-01-19T12:23:55.165Z INF/cli:doctor 51171 [] Using RethinkDB 2.4.4
2025-01-19T12:23:55.226Z INF/cli:doctor 51171 [] Using ADB 1.0.41
2025-01-19T12:23:57.174Z INF/cli:doctor 51171 [] Using GraphicsMagick 1.3.45
2025-01-19T12:24:06.609Z INF/cli:doctor 51171 [] Using ProtoBuf 29.3
2025-01-19T12:24:06.611Z ERR/cli:doctor 51171 [] ProtoBuf is currently 29.3 but needs to be >= 3

[noa-cohen-unity]

A deeper dive concluded in understanding another layer of the issue:
For the default group you created for me (db result pdf is attached), that is with "class": "standard", i get

{
	"success": false,
	"description": "Bad Request (this group cannot act as an origin one)"
}

for the api

http://localhost:7100/api/v1/devices/groups/ee1b6c4446ec43bbb8bad93bcd7187b6

This is clearly the origin class, i even looked at your code and saw the definition for an origin class:

service.isOriginGroup = function(_class) {
    return _class === 'bookable' || _class === 'standard'
  }

So im a bit confused, how can i remove devices from an origin class ?

Thanks.

[denis99999]

hi @noa-cohen-unity, first of all you need to read the user manual on the Group feature on doc/GroupFeature.pdf where everything is explained!
In short:

1. If you want to add devices to a new group from those in the Common group (Standard class), you must first create a new Origin group (Standard class or Bookable class), after which you can add certain devices to this new group using the Available Devices tab (devices that can be added from other Origin groups, as the Common group, will be displayed for selection)
2. If you want to add devices to a transient group (e.g. Once class) to make a reservation, you must first complete step 1 above by creating a Bookable group, after which you can add to your reservation group certain devices using the Available Devices tab. (devices in Standard groups will not be displayed for selection but only those in Bookable groups).

[noa-cohen-unity]

Hi @denis99999, thanks for the quick response!

I did read deeply the doc/GroupFeature.pdf, yet i didn't manage to allocate devices from my Standard group nor adding new devices to another group.

I did what you said and created a new group with Standard class and another one with Bookable class, the devices in the Common group are in the 'Group devices' section and i can't move them to the 'Available Devices' section.

I even tried to use the api /devices/groups/{id} and remove the devices but got
{ "success": false, "description": "Server too busy, please try again later" }

[denis99999]

@noa-cohen-unity , you have not to move devices of the Common group from the 'group devices' section to the 'Available devices' section, you did not understand how Group feature works, follow these instructions:

1. Stop and Start your STF server because your API error is suspicious, I hope you did not try to alter the database manually!
2. Use the UI
3. Create a Bookable group named "X"
4. In "X" group click on "Available Devices" (normally you should see devices of the Common group), and you have just to add one or more devices by clicking on the cart button, that's all!