-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ophyd_async
DerivedSignals
#1140
Use ophyd_async
DerivedSignals
#1140
Comments
Can I pick this up, I am going to have to do it for i10 id and current amplifier later. |
Sure, sounds good! |
Note that you will have linting/test issues until #1143 is sorted |
I have a quick try at making the change and I run into an issue, it appears the signal type is extracted from the type hint of the transformation function but at the moment it only support python build in type, if I try to use a custom type I get the following error:
which is caused by get_type_hints as ApertureValue is not define in _derived signal scope, I can make the device work by defining ApertureValue within _derived_signal.py. To Reproduce Expected behavior |
I think this can currently be done with the more complete API https://blueskyproject.io/ophyd-async/main/how-to/derive-one-signal-from-others.html#multi-derived-signal. I think it would be good to have this in the simple API if we can though, a common usecase we have is converting an |
bluesky/ophyd-async#843 should fix it, please could you test? |
Following bluesky/ophyd-async#661 there is now a DerivedSignal in ophyd_async that should be able to replace the
hardware_backed_signal
we have made indodal
.Acceptance Criteria
hardware_backed_signal
s are replaced byDerivedSignal
s fromophyd_async
The text was updated successfully, but these errors were encountered: