ENG-1197: fix personal settings migration, for all users insted of only the user who instantiated it (#639)

* fix personal settings migration, for all users insted of only the user who instantiated it

* coderabbit review points

Author: sid597

apps/roam/src/utils/getLeftSidebarSettings.ts

@@ -45,6 +45,7 @@ export type LeftSidebarConfig = {
   favoritesMigrated: BooleanSetting;
   sidebarMigrated: BooleanSetting;
   global: LeftSidebarGlobalSectionConfig;
+  allPersonalSections: AllUsersPersonalSections;
   personal: {
     uid: string;
     sections: LeftSidebarPersonalSectionConfig[];
@@ -125,14 +126,22 @@ const getPersonalSectionSettings = (
   };
 };
 
+export type AllUsersPersonalSections = {
+  [userUid: string]: {
+    uid: string;
+    sections: LeftSidebarPersonalSectionConfig[];
+  };
+};
+
 export const getLeftSidebarPersonalSectionConfig = (
   leftSidebarChildren: RoamBasicNode[],
+  userUid?: string,
 ): { uid: string; sections: LeftSidebarPersonalSectionConfig[] } => {
-  const userUid = window.roamAlphaAPI.user.uid();
+  const targetUserUid = userUid ?? window.roamAlphaAPI.user.uid();
 
   const personalLeftSidebarNode = getSubTree({
     tree: leftSidebarChildren,
-    key: userUid + "/Personal-Section",
+    key: targetUserUid + "/Personal-Section",
   });
 
   if (personalLeftSidebarNode.uid === "") {
@@ -173,7 +182,23 @@ export const getLeftSidebarPersonalSectionConfig = (
     sections,
   };
 };
+export const getAllLeftSidebarPersonalSectionConfigs = (
+  leftSidebarChildren: RoamBasicNode[],
+): AllUsersPersonalSections => {
+  const result: AllUsersPersonalSections = {};
+
+  leftSidebarChildren
+    .filter((node) => node.text.endsWith("/Personal-Section"))
+    .forEach((node) => {
+      const userUid = node.text.replace("/Personal-Section", "");
+      result[userUid] = getLeftSidebarPersonalSectionConfig(
+        leftSidebarChildren,
+        userUid,
+      );
+    });
 
+  return result;
+};
 export const getLeftSidebarSettings = (
   globalTree: RoamBasicNode[],
 ): LeftSidebarConfig => {
@@ -184,6 +209,9 @@ export const getLeftSidebarSettings = (
   const leftSidebarChildren = leftSidebarNode?.children || [];
   const global = getLeftSidebarGlobalSectionConfig(leftSidebarChildren);
   const personal = getLeftSidebarPersonalSectionConfig(leftSidebarChildren);
+  // TODO: remove this on complete migration task [ENG-1171: Remove `migrateLeftSideBarSettings`](https://linear.app/discourse-graphs/issue/ENG-1171/remove-migrateleftsidebarsettings)
+  const allPersonalSections =
+    getAllLeftSidebarPersonalSectionConfigs(leftSidebarChildren);
   const favoritesMigrated = getUidAndBooleanSetting({
     tree: leftSidebarChildren,
     text: "Favorites Migrated",
@@ -198,5 +226,6 @@ export const getLeftSidebarSettings = (
     sidebarMigrated,
     global,
     personal,
+    allPersonalSections,
   };
 };

apps/roam/src/utils/migrateLeftSidebarSettings.ts

@@ -51,11 +51,17 @@ export const migrateLeftSidebarSettings = async () => {
     await migrateSectionChildren(globalChildren);
   }
 
-  const personalSections = leftSidebarSettings.personal.sections;
-  for (const section of personalSections) {
-    const children = section.children || [];
-    if (children.length > 0) {
-      await migrateSectionChildren(children);
+
+  const allPersonalSections = leftSidebarSettings.allPersonalSections;
+
+  for (const [_, userPersonalSection] of Object.entries(
+    allPersonalSections,
+  )) {
+    for (const section of userPersonalSection.sections) {
+      const children = section.children || [];
+      if (children.length > 0) {
+        await migrateSectionChildren(children);
+      }
     }
   }