Allow configuration of reward address.

Allow setting a non-default reward script for masternodes, by editing
the masternode.conf file explicitly.  The RPC setupmasternode will not
generate such configuration lines for now, and also "old" masternode.conf
files will remain valid (with the default script).

Author: domob1812

divi/src/MasternodeBroadcastFactory.cpp

@@ -7,6 +7,7 @@
 #include <obfuscation.h>
 #include <chain.h>
 #include <base58address.h>
+#include <script/standard.h>
 #include <TransactionDiskAccessor.h>
 #include <timedata.h>
 #include <WalletTx.h>
@@ -108,6 +109,7 @@ bool createArgumentsFromConfig(
     bool collateralPrivKeyIsRemote,
     CTxIn& txin,
     std::pair<CKey,CPubKey>& masternodeKeyPair,
+    CScript& rewardScript,
     std::pair<CKey,CPubKey>& masternodeCollateralKeyPair,
     MasternodeTier& nMasternodeTier)
 {
@@ -143,6 +145,18 @@ bool createArgumentsFromConfig(
     {
         return false;
     }
+
+    if (configEntry.getRewardAddress().empty())
+        rewardScript = CMasternode::GetDefaultRewardScript(masternodeCollateralKeyPair.second);
+    else {
+        const CBitcoinAddress addr(configEntry.getRewardAddress());
+        if (!addr.IsValid()) {
+            strErrorRet = strprintf("Invalid reward address for masternode: %s", configEntry.getRewardAddress());
+            return false;
+        }
+        rewardScript = GetScriptForDestination(addr.Get());
+    }
+
     return true;
 }
 
@@ -160,6 +174,7 @@ bool CMasternodeBroadcastFactory::Create(
     const bool deferRelay = true;
     CTxIn txin;
     std::pair<CKey,CPubKey> masternodeCollateralKeyPair;
+    CScript rewardScript;
     std::pair<CKey,CPubKey> masternodeKeyPair;
     MasternodeTier nMasternodeTier;
 
@@ -171,6 +186,7 @@ bool CMasternodeBroadcastFactory::Create(
         collateralPrivateKeyIsRemote,
         txin,
         masternodeKeyPair,
+        rewardScript,
         masternodeCollateralKeyPair,
         nMasternodeTier))
     {
@@ -181,6 +197,7 @@ bool CMasternodeBroadcastFactory::Create(
         txin,
         CService(configEntry.getIp()),
         pubkeyCollateralAddress,
+        rewardScript,
         masternodeKeyPair.second,
         nMasternodeTier,
         deferRelay,
@@ -210,6 +227,7 @@ bool CMasternodeBroadcastFactory::Create(
 
     CTxIn txin;
     std::pair<CKey,CPubKey> masternodeCollateralKeyPair;
+    CScript rewardScript;
     std::pair<CKey,CPubKey> masternodeKeyPair;
     MasternodeTier nMasternodeTier;
 
@@ -221,6 +239,7 @@ bool CMasternodeBroadcastFactory::Create(
         collateralPrivateKeyIsRemote,
         txin,
         masternodeKeyPair,
+        rewardScript,
         masternodeCollateralKeyPair,
         nMasternodeTier))
     {
@@ -231,6 +250,7 @@ bool CMasternodeBroadcastFactory::Create(
                 CService(strService),
                 masternodeCollateralKeyPair.first,
                 masternodeCollateralKeyPair.second,
+                rewardScript,
                 masternodeKeyPair.first,
                 masternodeKeyPair.second,
                 nMasternodeTier,
@@ -292,6 +312,7 @@ void CMasternodeBroadcastFactory::createWithoutSignatures(
     const CTxIn& txin,
     const CService& service,
     const CPubKey& pubKeyCollateralAddressNew,
+    const CScript& rewardScript,
     const CPubKey& pubKeyMasternodeNew,
     const MasternodeTier nMasternodeTier,
     bool deferRelay,
@@ -301,7 +322,9 @@ void CMasternodeBroadcastFactory::createWithoutSignatures(
              CBitcoinAddress(pubKeyCollateralAddressNew.GetID()).ToString(),
              pubKeyMasternodeNew.GetID().ToString());
 
-    mnbRet = CMasternodeBroadcast(service, txin, pubKeyCollateralAddressNew, pubKeyMasternodeNew, nMasternodeTier, PROTOCOL_VERSION);
+    mnbRet = CMasternodeBroadcast(service, txin,
+                                  pubKeyCollateralAddressNew, rewardScript, pubKeyMasternodeNew,
+                                  nMasternodeTier, PROTOCOL_VERSION);
     const CMasternodePing mnp = (deferRelay
                                     ? createDelayedMasternodePing(mnbRet)
                                     : createCurrentPing(txin));
@@ -330,6 +353,7 @@ bool CMasternodeBroadcastFactory::Create(
     const CService& service,
     const CKey& keyCollateralAddressNew,
     const CPubKey& pubKeyCollateralAddressNew,
+    const CScript& rewardScript,
     const CKey& keyMasternodeNew,
     const CPubKey& pubKeyMasternodeNew,
     const MasternodeTier nMasternodeTier,
@@ -341,7 +365,7 @@ bool CMasternodeBroadcastFactory::Create(
     if (ReindexingOrImportingIsActive()) return false;
 
     createWithoutSignatures(
-        txin,service,pubKeyCollateralAddressNew,pubKeyMasternodeNew,nMasternodeTier,deferRelay,mnbRet);
+        txin,service,pubKeyCollateralAddressNew,rewardScript,pubKeyMasternodeNew,nMasternodeTier,deferRelay,mnbRet);
 
     if(!provideSignatures(keyMasternodeNew,pubKeyMasternodeNew,keyCollateralAddressNew,mnbRet,strErrorRet))
     {

divi/src/MasternodeBroadcastFactory.h

@@ -42,6 +42,7 @@ class CMasternodeBroadcastFactory
         const CTxIn& txin,
         const CService& service,
         const CPubKey& pubKeyCollateralAddressNew,
+        const CScript& rewardScript,
         const CPubKey& pubKeyMasternodeNew,
         MasternodeTier nMasternodeTier,
         bool deferRelay,
@@ -63,6 +64,7 @@ class CMasternodeBroadcastFactory
                        const CService& service,
                        const CKey& keyCollateralAddressNew,
                        const CPubKey& pubKeyCollateralAddressNew,
+                       const CScript& rewardScript,
                        const CKey& keyMasternodeNew,
                        const CPubKey& pubKeyMasternodeNew,
                        MasternodeTier nMasternodeTier,

divi/src/masternode.cpp

@@ -132,6 +132,11 @@ CMasternode& CMasternode::operator=(CMasternode from)
 }
 
 CScript CMasternode::GetDefaultRewardScript() const
+{
+    return GetDefaultRewardScript(pubKeyCollateralAddress);
+}
+
+CScript CMasternode::GetDefaultRewardScript(const CPubKey& pubKeyCollateralAddress)
 {
     return GetScriptForDestination(pubKeyCollateralAddress.GetID());
 }
@@ -244,13 +249,13 @@ bool CMasternode::IsValidNetAddr() const
 
 CMasternodeBroadcast::CMasternodeBroadcast(
     const CService& newAddr, const CTxIn& newVin,
-    const CPubKey& pubKeyCollateralAddressNew, const CPubKey& pubKeyMasternodeNew,
+    const CPubKey& pubKeyCollateralAddressNew, const CScript& rewardScriptIn, const CPubKey& pubKeyMasternodeNew,
     const MasternodeTier nMasternodeTier, const int protocolVersionIn)
 {
     vin = newVin;
     addr = newAddr;
     pubKeyCollateralAddress = pubKeyCollateralAddressNew;
-    rewardScript = GetDefaultRewardScript();
+    rewardScript = rewardScriptIn;
     pubKeyMasternode = pubKeyMasternodeNew;
     protocolVersion = protocolVersionIn;
     nTier = nMasternodeTier;

divi/src/masternode.h

@@ -90,6 +90,7 @@ class CMasternode
     /** Returns the "default" reward script, which is the one
      *  matching the collateral address.  */
     CScript GetDefaultRewardScript() const;
+    static CScript GetDefaultRewardScript(const CPubKey& pubKeyCollateralAddress);
 
     /** Calculates the score of the current masternode, based on the given
      *  scoring hash.  It should be the result of GetBlockHashForScoring of
@@ -149,6 +150,7 @@ class CMasternodeBroadcast : public CMasternode
         const CService& newAddr,
         const CTxIn& newVin,
         const CPubKey& pubKeyCollateralAddress,
+        const CScript& rewardScriptIn,
         const CPubKey& pubKeyMasternode,
         MasternodeTier nMasternodeTier,
         int protocolVersionIn);

divi/src/masternodeconfig.cpp

@@ -41,9 +41,10 @@ boost::filesystem::path GetMasternodeConfigFile(const Settings& settings)
 } // anonymous namespace
 
 void CMasternodeConfig::add(const std::string& alias, const std::string& ip, const std::string& privKey,
-                            const std::string& txHash, const std::string& outputIndex)
+                            const std::string& txHash, const std::string& outputIndex,
+                            const std::string& rewardAddr)
 {
-    entries.emplace_back(alias, ip, privKey, txHash, outputIndex);
+    entries.emplace_back(alias, ip, privKey, txHash, outputIndex, rewardAddr);
 }
 
 bool CMasternodeConfig::read(const Settings& settings, std::string& strErr)
@@ -87,7 +88,12 @@ bool CMasternodeConfig::read(const Settings& settings, std::string& strErr)
             }
         }
 
-        add(alias, ip, privKey, txHash, outputIndex);
+        /* This might fail if there is no address, but that is fine and we will
+           just leave the string empty in that case.  */
+        std::string rewardAddr;
+        iss >> rewardAddr;
+
+        add(alias, ip, privKey, txHash, outputIndex, rewardAddr);
     }
 
     streamConfig.close();

divi/src/masternodeconfig.h

@@ -26,17 +26,20 @@ class CMasternodeConfig
         std::string privKey;
         std::string txHash;
         std::string outputIndex;
+        std::string rewardAddress;
 
     public:
         CMasternodeEntry(const std::string& alias, const std::string& ip,
                          const std::string& privKey,
-                         const std::string& txHash, const std::string& outputIndex)
+                         const std::string& txHash, const std::string& outputIndex,
+                         const std::string& rewardAddress)
         {
             this->alias = alias;
             this->ip = ip;
             this->privKey = privKey;
             this->txHash = txHash;
             this->outputIndex = outputIndex;
+            this->rewardAddress = rewardAddress;
         }
 
         const std::string& getAlias() const
@@ -89,6 +92,16 @@ class CMasternodeConfig
             this->ip = ip;
         }
 
+        const std::string& getRewardAddress() const
+        {
+            return rewardAddress;
+        }
+
+        void setRewardAddress(const std::string& addr)
+        {
+            this->rewardAddress = addr;
+        }
+
         /** Tries to parse the entry's input reference into an outpoint.
          *  Returns true on success.  */
         bool parseInputReference(COutPoint& outp) const;
@@ -99,7 +112,8 @@ class CMasternodeConfig
     void clear();
     bool read(const Settings& settings, std::string& strErr);
     void add(const std::string& alias, const std::string& ip, const std::string& privKey,
-             const std::string& txHash, const std::string& outputIndex);
+             const std::string& txHash, const std::string& outputIndex,
+             const std::string& rewardAddr);
     const std::vector<CMasternodeEntry>& getEntries() const;
     int getCount() const;
 

divi/src/rpcmasternode.cpp

@@ -271,7 +271,7 @@ Value setupmasternode(const Array& params, bool fHelp)
     if (ipAndPort.find(':') == std::string::npos)
         ipAndPort += ":" + std::to_string(Params().GetDefaultPort());
 
-    CMasternodeConfig::CMasternodeEntry config(alias,ipAndPort,CBitcoinSecret(masternodeKey).ToString(),txHash,outputIndex);
+    CMasternodeConfig::CMasternodeEntry config(alias,ipAndPort,CBitcoinSecret(masternodeKey).ToString(),txHash,outputIndex, "");
 
     CMasternodeBroadcast mnb;
     std::string errorMsg;

divi/src/test/ActiveMasternode_tests.cpp

@@ -30,7 +30,7 @@ class ActiveMasternodeTestFixture
 
     void AddDummyConfiguration(CTxIn txIn, CService service)
     {
-        configurations_->add("dummy configuration", service.ToString(), "", txIn.prevout.hash.ToString(), std::to_string(txIn.prevout.n));
+        configurations_->add("dummy configuration", service.ToString(), "", txIn.prevout.hash.ToString(), std::to_string(txIn.prevout.n), "");
     }
     void disableMasternode()
     {
@@ -131,4 +131,4 @@ BOOST_AUTO_TEST_CASE(willCannotResetStatusOfInactiveMasternodeWhenChainSyncIsReq
     BOOST_CHECK(activeMasternode_->status == ACTIVE_MASTERNODE_STARTED);
 }
 
-BOOST_AUTO_TEST_SUITE_END()
+BOOST_AUTO_TEST_SUITE_END()