Merge pull request #16 from peter279k/test_enhancement

Test enhancement

Author: DivineOmega

.travis.yml

@@ -3,11 +3,15 @@ dist: trusty
 php:
   - '7.1.18'
   - '7.2'
+  - nightly
   - 'hhvm'
+matrix:
+  allow_failures:
+    - php: nightly
 install:
-  - composer update
+  - composer install
 script:
  - ./vendor/bin/phpunit --coverage-clover ./tests/Logs/clover.xml
  - ./vendor/bin/psalm
 after_script:
- - php vendor/bin/php-coveralls -v
+ - php vendor/bin/php-coveralls -v

composer.json

@@ -9,7 +9,7 @@
         }
     ],
     "require-dev": {
-        "phpunit/phpunit": "^5.7",
+        "phpunit/phpunit": "^6.5",
         "fzaninotto/faker": "^1.7",
         "vimeo/psalm": "^1",
         "php-coveralls/php-coveralls": "^2.1"
@@ -22,6 +22,11 @@
             "src/PasswordExposedFunction.php"
         ]
     },
+    "autoload-dev": {
+        "psr-4": {
+            "DivineOmega\\PasswordExposed\\Tests\\": "tests/"
+        }
+    },
     "license": "LGPL-3.0-only",
     "require": {
         "php": ">=5.6",

tests/Unit/BundleInjectionTest.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace DivineOmega\PasswordExposed\Tests;
+
 use DivineOmega\PasswordExposed\PasswordExposedChecker;
 use DivineOmega\PasswordExposed\PasswordStatus;
 use ParagonIE\Certainty\Bundle;

tests/Unit/PasswordExposedTest.php

@@ -1,6 +1,9 @@
 <?php
 
+namespace DivineOmega\PasswordExposed\Tests;
+
 use DivineOmega\PasswordExposed\PasswordStatus;
+use Faker\Factory;
 use PHPUnit\Framework\TestCase;
 
 class PasswordExposedTest extends TestCase
@@ -10,13 +13,21 @@ public function testFunctionExists()
         $this->assertTrue(function_exists('password_exposed'));
     }
 
-    public function testExposedPasswords()
+    public function exposedPasswordsProvider()
     {
-        $passwords = ['test', 'password', 'hunter2'];
+        return [
+            ['test'],
+            ['password'],
+            ['hunter2'],
+        ];
+    }
 
-        foreach ($passwords as $password) {
-            $this->assertEquals(password_exposed($password), PasswordStatus::EXPOSED);
-        }
+    /**
+     * @dataProvider exposedPasswordsProvider
+     */
+    public function testExposedPasswords($password)
+    {
+        $this->assertEquals(password_exposed($password), PasswordStatus::EXPOSED);
     }
 
     public function testNotExposedPasswords()
@@ -26,7 +37,7 @@ public function testNotExposedPasswords()
 
     private function getPasswordUnlikelyToBeExposed()
     {
-        $faker = Faker\Factory::create();
+        $faker = Factory::create();
 
         $password = '';