Dropdown not rendering correctly

[dekhaus]

Hi

In previous Django projects I've used django-admin-row-actions and its worked fine.

I'm trying to get it to work in a Django 2.1 project. Functionally it works - but the drop-down is not rendering correctly (see screenshot)

How do I fix ?

Thanks
Dave

[andybak]

Looks like the javascript isn't running. Any errors in the console or 404s in the network tab?

[dekhaus]

None.

Thanks
Dave

[andybak]

Ah. Until we upgrade to Django 2.x ourselves we won't be much help I'm afraid. It's planned but not in the immediate future.

[dekhaus]

Hi Just curious if you have an update regarding when you’re going to update django-admin-row-actions to work properly with Django 2 ? Thanks Dave On September 20, 2018 at 10:32:05 AM, Andy Baker (notifications@github.com) wrote: Ah. Until we upgrade to Django 2.x ourselves we won't be much help I'm afraid. It's planned but not in the immediate future. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#18 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAelkGAgYxNQ6ZSw5rsjmgAoFaGNE1bks5uc9EUgaJpZM4WyG36> .

[andybak]

Nothing definite right now - Q1 next year is likely.

[tobiase]

The way to add assets to the ModelAdmin seems to have changed.
I overcame the issue by monkeypatching the AdminRowActionsMixin.

from django.contrib.admin import ModelAdmin
from django_admin_row_actions import AdminRowActionsMixin
from django import forms

def admin_row_actions_media(self):
    return (ModelAdmin.media.fget)(self) + forms.Media(
        css={"all": ["css/jquery.dropdown.min.css"]}, js=["js/jquery.dropdown.min.js"]
    )


setattr(AdminRowActionsMixin, "media", property(admin_row_actions_media))

[andybak]

@tobiase - looks fairly simple to turn that into pull request if you have the time (ideally in a backwards compatible form)

[guglielmo]

@tobiase, see a pull request I just made

[andybak]

@fruitschen Can you take a look at the above PR?

[fruitschen]

Sorry for the delay, I just merged the PR.
I've tested it against a django1.8 site.

chen

[guglielmo]

Is this going to be released as version 0.0.5 on pyPI, as well?

[fruitschen]

sure.

[fruitschen]

New to pypi packaging...
@andybak I don't have enough permission to do it. Do you mind uploading the new version to pypi?

[blag]

@fruitschen I'm the owner of the project on PyPI, I can add you. What is your username on PyPI?