Skip to content

The first accordion in "Brief intro to the command line" renders bad #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mcagl opened this issue Oct 11, 2024 · 2 comments
Closed

The first accordion in "Brief intro to the command line" renders bad #1851

mcagl opened this issue Oct 11, 2024 · 2 comments

Comments

@mcagl
Copy link
Contributor

mcagl commented Oct 11, 2024

Issue description

The link is this: https://tutorial.djangogirls.org/en/installation/#intro-command-line

All the content for "Opening: Windows" is outside of the accordion, but looking at the source code it is expected to render inside the accordion.

I tried to understand why, and I did these experiments:

  • I added another <sec data-title=... content, containing a <ul>, and then this new one renders badly, and the pre-existing "Windows" one renders good.
  • I removed the "dummy" section, and added only a <!endsec--> before the "Windows" section, and then it rendered good

It seems that above this section there is a non-closed section, but it's not the case (at least to my eyes).

I don't know how to solve this.

Language

I looked at the english version

Operating system

It's not related to one operating system

Screenshots

This is the bad render:

bad

This is the good render:

good

@mcagl
Copy link
Contributor Author

mcagl commented Nov 15, 2024

When #1855 will be fixed, and the website will be deployed, there is the possibility that this issue can be closed (after checking the deployed website obviously), because when I locally compile the tutorial (during development of #1854) the problem is not here anymore.

@mcagl
Copy link
Contributor Author

mcagl commented Nov 29, 2024

I am closing this issue because after the deploy fix and the PR merged in the codebase, the website now renders correctly

@mcagl mcagl closed this as completed Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant