Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finally someone! #1

Open
shaps80 opened this issue Aug 27, 2024 · 4 comments · May be fixed by #2
Open

Finally someone! #1

shaps80 opened this issue Aug 27, 2024 · 4 comments · May be fixed by #2
Assignees
@DominikBucher12

Comments

@shaps80
Copy link

shaps80 commented Aug 27, 2024

So I actually worked out most of the kinks as you did. You had some slightly improved solutions though so thank you for that!!

I'm now trying to get nested lists working.

Some issues I'm personally still working through.

  • Not sure when/where to use NSTextListElement
    • Figured it might be necessary for nesting?
    • Also noticed it had an API for styling the marker, so I wanted to try it out – no luck so far
    • It seemed to break things if I include it, but I'm sure I'm just using it wrong
    • No examples examples of this anywhere AFAICT
  • I did get a rough experiment working for nesting
    • Seems to be a very manual process so far
    • Still couldn't control indentation AFAICT
    • You essentially nest the [list] but I'm sure I'm still not using it right

If you happen to try any of the above and have feedback, I'd love to hear about your explorations!
@shaps80
Copy link
Author

shaps80 commented Aug 27, 2024

Wow now span and attacks happening in GitHub comments

@DominikBucher12
Copy link
Owner

Hello @shaps80 thanks for your issue and sorry for such a late reply, I try to be open source guy, but alongside with other stuff I do I do not have that much time. Also this got somehow lost in ton of emails which is sad...

However I will take a look into those issues...

Feel free to create a Pull Request with description where and what is missing and I can see what I can do :)

@DominikBucher12 DominikBucher12 self-assigned this Oct 16, 2024
@DominikBucher12
Copy link
Owner

DominikBucher12 commented Oct 16, 2024 •
edited
Loading

hello @shaps80 again 👋

I dealt with this some while back and the indentation is quite easy actually.

You can forgot about NSTextListElement (I had strange feeling like this is another class, which should be internal/private object of TextKit2 similar to other stuff)

Now the problem is that we need to bind this UX to user typing actually rather than setting this with buttons... Please see feature/nested_lists branch and feel free to modify this :)

Nested.lists.Demo.mp4

@DominikBucher12 DominikBucher12 linked a pull request Oct 16, 2024 that will close this issue
[WIP] Nested list implementation #2
Open
@shaps80
Copy link
Author

shaps80 commented Oct 17, 2024

Oh that looks great! I'll take a look as I need to revisit the lists in our codebase anyway. Thank you for giving it a shot. Interesting about NSTextElement, you could be right tbh. Thank you!

Also I understand, I have 2 kids so my open-source contributions have been lacking since they were born 😂 – still, I appreciate your efforts!

@github-staff github-staff deleted a comment from YeGop0218 Oct 28, 2024
@github-staff github-staff deleted a comment from YeGop0218 Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DominikBucher12 DominikBucher12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Nested list implementation DominikBucher12/TextKit2-Interactive-Lists
2 participants
@shaps80 @DominikBucher12