refactor: 完成RPC服务端与客户端的标准化重构

本次提交进行了多项核心重构与功能完善：
1.  移除冗余代码与废弃文件：删除pkg/indexing/service.go多余空行、ISSUES.md和TODO.md文档
2.  标准化RPC结构体：将内部结果体迁移到pkg/rpc包统一管理，包括MemoryCountResult、FSReadResult、Optimize相关结构体等
3.  重构RPC注册逻辑：将handler注册改为使用map集中管理，提升可维护性
4.  完善空指针保护：为kvstore操作、事件发送等场景增加nil检查
5.  增加panic捕获：为多个后台goroutine增加崩溃日志捕获，提升服务稳定性
6.  优化日志格式：将fmt格式化日志改为结构化日志参数形式
7.  新增RPC客户端测试套件：覆盖全部RPC方法的单元测试
8.  重构文件删除逻辑：新增递归删除和强制删除参数，优化fs.rm接口行为
9.  简化模型参数处理：移除内部重复的modelGetParams结构体，复用rpc包中定义的结构

Author: DotNetAge

ISSUES.md

@@ -94,7 +94,7 @@ func DefaultApp(mindxConfig *MindxConfig) (*App, error) {
 	var err error
 	err = godotenv.Load()
 	if err != nil {
-		logger.Warn("WARNING: failed to load .env file: %v", err)
+		logger.Warn("WARNING: failed to load .env file", "error", err)
 	}
 
 	constants.SYSTEM_INFO_NAME = "MindX"
@@ -167,7 +167,7 @@ func DefaultApp(mindxConfig *MindxConfig) (*App, error) {
 		var embErr error
 		emb, embErr = memory.NewEmbedderFromConfig(modelPath)
 		if embErr != nil {
-			logger.Warn("Failed to create embedder, memory disabled: %v", embErr)
+			logger.Warn("Failed to create embedder, memory disabled", "error", embErr)
 		}
 	}
 
@@ -204,7 +204,7 @@ func resolveCurrentAgentName(cfg *MindxConfig, agents *config.AgentRegistry, log
 		if agents.Get(cfg.LastAgent) != nil {
 			return cfg.LastAgent
 		}
-		logger.Warn("last_agent %q not found in registry, will use fallback", cfg.LastAgent)
+		logger.Warn("last_agent not found in registry, will use fallback", "agent", cfg.LastAgent)
 	}
 
 	if list := agents.List(); len(list) > 0 {
@@ -562,7 +562,7 @@ func (a *App) createRuntime(agentName string) (*agents.Runtime, error) {
 				Logger:    a.logger,
 			})
 			if ltErr != nil {
-				a.logger.Warn("Failed to create long-term memory for agent %q: %v", agent.Name, ltErr)
+				a.logger.Warn("Failed to create long-term memory", "agent", agent.Name, "error", ltErr)
 			} else {
 				opts = append(opts, agents.WithMemory(ltMem))
 				a.logger.Info("createRuntime: long-term memory OK", "agent", agentName)

TODO.md

@@ -675,23 +675,27 @@ func (d *Daemon) autoUpdateLoop(ctx context.Context) {
 					"latest", info.LatestVersion,
 				)
 				// 通知客户端更新即将开始
-				d.gw.BroadcastNotification("update_started", map[string]interface{}{
-					"type": "update_started",
-					"data": map[string]string{
-						"version": info.LatestVersion,
-					},
-				})
+				if d.gw != nil {
+					d.gw.BroadcastNotification("update_started", map[string]interface{}{
+						"type": "update_started",
+						"data": map[string]string{
+							"version": info.LatestVersion,
+						},
+					})
+				}
 				// 自动下载并安装新二进制（但不要重启，只记录日志通知用户）
 				if err := d.updater.DownloadAndInstall(ctx); err != nil {
 					d.logger.Warn("auto-update: download and install failed", "error", err)
 				} else {
 					d.logger.Info("auto-update: update installed. User should restart the daemon.")
-					d.gw.BroadcastNotification("update_installed", map[string]interface{}{
-						"type": "update_installed",
-						"data": map[string]string{
-							"version": info.LatestVersion,
-						},
-					})
+					if d.gw != nil {
+						d.gw.BroadcastNotification("update_installed", map[string]interface{}{
+							"type": "update_installed",
+							"data": map[string]string{
+								"version": info.LatestVersion,
+							},
+						})
+					}
 				}
 			} else {
 				d.logger.Info("auto-update: already up-to-date", "version", info.CurrentVersion)
@@ -985,6 +989,11 @@ func (d *Daemon) Start(ctx context.Context) error {
 	// ── Hot-reload: watch agents/skills directories for file changes ──
 	d.hotReload = NewHotReloadWatcher(d.app, d.logger)
 	go func() {
+		defer func() {
+			if r := recover(); r != nil && d.logger != nil {
+				d.logger.Error("hot-reload watcher: goroutine panic", fmt.Errorf("%v", r))
+			}
+		}()
 		if err := d.hotReload.Start(ctx); err != nil && d.logger != nil {
 			d.logger.Warn("hot-reload watcher exited with error", "error", err)
 		}
@@ -999,6 +1008,11 @@ func (d *Daemon) Start(ctx context.Context) error {
 			ctx, cancel := context.WithCancel(context.Background())
 			d.watchCancel = cancel
 			go func() {
+				defer func() {
+					if r := recover(); r != nil {
+						d.logger.Error("auto-restore filewatch: goroutine panic", fmt.Errorf("%v", r))
+					}
+				}()
 				if err := d.kbWatch.Start(ctx); err != nil {
 					d.logger.Warn("auto-restore: filewatch exited with error", "error", err)
 				}

internal/core/app.go

@@ -10,6 +10,9 @@ import (
 )
 
 func (d *Daemon) sendEvent(clientID, sessionID string, respType gateway.ResponseType, title string, data string, opts ...gateway.ResponseOption) {
+	if d.gw == nil {
+		return
+	}
 	allOpts := append([]gateway.ResponseOption{gateway.WithSessionID(sessionID)}, opts...)
 	_ = d.gw.SendResponse(clientID, respType, title, data, allOpts...)
 }
@@ -28,6 +31,9 @@ func (d *Daemon) broadcastScheduleEvent(sessionID, agent, eventType string, data
 }
 
 func (d *Daemon) sendExecutionSummary(clientID, sessionID string, summary goharnessevents.ExecutionSummaryData, agentName string) {
+	if d.gw == nil {
+		return
+	}
 	d.logger.Info("[SSE-TRACE L5] sendExecutionSummary: total_tokens=" + fmt.Sprint(summary.TokensUsed.TotalTokens) +
 		" input=" + fmt.Sprint(summary.TokensUsed.InputTokens) +
 		" output=" + fmt.Sprint(summary.TokensUsed.OutputTokens))

internal/svc/daemon.go

@@ -98,10 +98,6 @@ func (d *Daemon) handleFSHome(_ context.Context, _ json.RawMessage) (any, error)
 	return map[string]string{"path": defaultFSHome()}, nil
 }
 
-type fsReadResult struct {
-	Content string `json:"content"`
-}
-
 func (d *Daemon) handleFSRead(_ context.Context, params json.RawMessage) (any, error) {
 	var p rpc.FSReadParams
 	if err := unmarshalParams(params, &p); err != nil {
@@ -126,7 +122,7 @@ func (d *Daemon) handleFSRead(_ context.Context, params json.RawMessage) (any, e
 	if err != nil {
 		return nil, fmt.Errorf("cannot read file: %w", err)
 	}
-	return fsReadResult{Content: string(data)}, nil
+	return rpc.FSReadResult{Content: string(data)}, nil
 }
 
 func (d *Daemon) handleFSWrite(_ context.Context, params json.RawMessage) (any, error) {
@@ -187,16 +183,28 @@ func (d *Daemon) handleFSRm(_ context.Context, params json.RawMessage) (any, err
 		return nil, fmt.Errorf("cannot access path: %w", err)
 	}
 	if info.IsDir() {
-		// Only remove empty directories to avoid accidental data loss
-		entries, err := os.ReadDir(absPath)
-		if err != nil {
-			return nil, fmt.Errorf("cannot read directory: %w", err)
-		}
-		if len(entries) > 0 {
-			return nil, fmt.Errorf("directory not empty: %s", p.Path)
-		}
-		if err := os.Remove(absPath); err != nil {
-			return nil, fmt.Errorf("cannot remove directory: %w", err)
+		if p.Recurse {
+			if err := os.RemoveAll(absPath); err != nil {
+				return nil, fmt.Errorf("cannot remove directory tree: %w", err)
+			}
+		} else {
+			entries, err := os.ReadDir(absPath)
+			if err != nil {
+				return nil, fmt.Errorf("cannot read directory: %w", err)
+			}
+			if len(entries) > 0 {
+				if p.Force {
+					if err := os.RemoveAll(absPath); err != nil {
+						return nil, fmt.Errorf("cannot force remove directory: %w", err)
+					}
+				} else {
+					return nil, fmt.Errorf("directory not empty: %s", p.Path)
+				}
+			} else {
+				if err := os.Remove(absPath); err != nil {
+					return nil, fmt.Errorf("cannot remove directory: %w", err)
+				}
+			}
 		}
 	} else {
 		if err := os.Remove(absPath); err != nil {
@@ -234,10 +242,6 @@ func (d *Daemon) handleFSMv(_ context.Context, params json.RawMessage) (any, err
 
 // ── 新增：reveal ──
 
-type fsRevealResult struct {
-	Status string `json:"status"`
-}
-
 // handleFSReveal opens the file's parent directory in the native file manager,
 // and on macOS also highlights/selects the file.
 func (d *Daemon) handleFSReveal(_ context.Context, params json.RawMessage) (any, error) {
@@ -276,7 +280,7 @@ func (d *Daemon) handleFSReveal(_ context.Context, params json.RawMessage) (any,
 		}
 	}
 
-	return fsRevealResult{Status: "ok"}, nil
+	return rpc.FSRevealResult{Status: "ok"}, nil
 }
 
 // ── HTTP download ──

internal/svc/event_dispatcher.go

@@ -125,12 +125,6 @@ func (d *Daemon) handleKBSyncProject(_ context.Context, params json.RawMessage)
 // kb.stats — 获取知识库文件索引进度统计
 // ---------------------------------------------------------------------------
 
-type kbStatsResult struct {
-	TotalFiles   int `json:"total_files"`
-	IndexedFiles int `json:"indexed_files"`
-	TotalChunks  int `json:"total_chunks"`
-}
-
 func (d *Daemon) handleKBStats(_ context.Context, params json.RawMessage) (any, error) {
 	var p struct {
 		ProjectDir string `json:"project_dir"`
@@ -170,7 +164,7 @@ func (d *Daemon) handleKBStats(_ context.Context, params json.RawMessage) (any,
 		"total_chunks", totalChunks,
 	)
 
-	return kbStatsResult{
+	return rpc.KBStatsResult{
 		TotalFiles:   totalFiles,
 		IndexedFiles: indexedFiles,
 		TotalChunks:  totalChunks,

internal/svc/handler_fs.go

@@ -139,6 +139,9 @@ func (d *Daemon) handleKVDelete(_ context.Context, params json.RawMessage) (any,
 
 // kvDeleteInternal deletes a key from the default bucket.
 func (d *Daemon) kvDeleteInternal(key string) error {
+	if d.kvStore == nil {
+		return fmt.Errorf("kvstore not available")
+	}
 	return d.kvStore.Update(func(tx *bbolt.Tx) error {
 		b := tx.Bucket([]byte(kvStoreBucket))
 		if b == nil {

internal/svc/handler_kb.go

@@ -237,9 +237,9 @@ func (d *Daemon) handleMemoryGetChunks(_ context.Context, params json.RawMessage
 	d.logger.Info("memory.get_chunks called", "doc_id", p.DocID, "returned", len(items))
 
 	return struct {
-		DocID  string         `json:"doc_id"`
+		DocID  string          `json:"doc_id"`
 		Chunks []rpc.ChunkItem `json:"chunks"`
-		Count  int            `json:"count"`
+		Count  int             `json:"count"`
 	}{
 		DocID:  p.DocID,
 		Chunks: items,
@@ -251,10 +251,6 @@ func (d *Daemon) handleMemoryGetChunks(_ context.Context, params json.RawMessage
 // memory.count — 获取 RAG 索引中的分块总数
 // ---------------------------------------------------------------------------
 
-type memoryCountResult struct {
-	Count int `json:"count"`
-}
-
 func (d *Daemon) handleMemoryCount(_ context.Context, _ json.RawMessage) (any, error) {
 	mem := d.sharedMemory
 	if mem == nil {
@@ -273,7 +269,7 @@ func (d *Daemon) handleMemoryCount(_ context.Context, _ json.RawMessage) (any, e
 
 	d.logger.Info("memory.count called", "count", count)
 
-	return memoryCountResult{Count: count}, nil
+	return rpc.MemoryCountResult{Count: count}, nil
 }
 
 // ---------------------------------------------------------------------------
@@ -310,6 +306,11 @@ func (d *Daemon) handleFilewatchStart(_ context.Context, params json.RawMessage)
 	d.logger.Info("filewatch.start: starting filewatch service")
 
 	go func() {
+		defer func() {
+			if r := recover(); r != nil {
+				d.logger.Error("filewatch.start: goroutine panic", fmt.Errorf("%v", r))
+			}
+		}()
 		if err := d.kbWatch.Start(ctx); err != nil {
 			d.logger.Warn("filewatch.start: service exited with error", "error", err)
 		}

internal/svc/handler_kvstore.go

@@ -49,12 +49,8 @@ func (d *Daemon) handleProviderList(_ context.Context, _ json.RawMessage) (any,
 	return result, nil
 }
 
-type modelGetParams struct {
-	Name string `json:"name"`
-}
-
 func (d *Daemon) handleModelGet(_ context.Context, params json.RawMessage) (any, error) {
-	var p modelGetParams
+	var p rpc.ModelGetParams
 	if err := unmarshalParams(params, &p); err != nil {
 		return nil, err
 	}