Skip to content

Commit d7d30a4

Browse files
authored
Merge pull request #46 from DropThe8bit/feat/easterEggVoice
[refactor] easterEggVoice S3 업로드 연동 및 좌표 검증 로직 수정, JSON 매핑 로직 개선
2 parents c185756 + 8dd5fca commit d7d30a4

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/main/java/everTale/everTale_be/domain/easterEgg/dto/easterEggVoice/request/EasterEggVoiceRequestDto.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package everTale.everTale_be.domain.easterEgg.dto.easterEggVoice.request;
22

3+
import com.fasterxml.jackson.annotation.JsonProperty;
34
import io.swagger.v3.oas.annotations.media.Schema;
45
import lombok.Getter;
56
import lombok.NoArgsConstructor;
@@ -8,9 +9,11 @@
89
@NoArgsConstructor
910
public class EasterEggVoiceRequestDto {
1011

12+
@JsonProperty("xCoordinate")
1113
@Schema(description = "사용자가 클릭한 이미지의 X 좌표", example = "135.0")
1214
private float xCoordinate;
1315

16+
@JsonProperty("yCoordinate")
1417
@Schema(description = "사용자가 클릭한 이미지의 Y 좌표", example = "210.0")
1518
private float yCoordinate;
1619
}

src/main/java/everTale/everTale_be/domain/easterEgg/service/EasterEggVoiceService.java

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ public void createEasterEggVoice(Long sceneId, MultipartFile voiceFile, EasterEg
3434
validateParent();
3535
Scene scene = findScene(sceneId);
3636

37-
// String voiceUrl = s3Manager.uploadFile(voiceFile, "eastereggs/audios"); 추후에 이걸로 수정할 예정
38-
String voiceUrl = voiceFile.getOriginalFilename();
37+
String voiceUrl = s3Manager.uploadFile(voiceFile, "eastereggs/audios");
3938

4039
EasterEggVoice voice = EasterEggVoice.builder()
4140
.scene(scene)
@@ -56,7 +55,7 @@ public void deleteEasterEggVoice(Long sceneId){
5655
.orElseThrow(()-> new NotFoundHandler(ErrorStatus.EASTER_EGG_VOICE_NOT_FOUND));
5756
Scene scene = voice.getScene();
5857
scene.setEasterEggVoice(null);
59-
// s3Manager.deleteFile(voice.getVoiceFile()); 추후에 주석 해제 예정
58+
s3Manager.deleteFile(voice.getVoiceFile());
6059
easterEggVoiceRepository.delete(voice);
6160
log.info("삭제 완료: audioId = {}", voice.getId());
6261
}
@@ -75,10 +74,10 @@ public String getVoiceUrl(Long sceneId, EasterEggVoiceRequestDto requestDto) {
7574
private boolean isInsideArea(EasterEggVoice voice, float clickX, float clickY) {
7675
float xLeft = voice.getXCoordinate() - voice.getWidth();
7776
float xRight = voice.getXCoordinate() + voice.getWidth();
78-
float yTop = voice.getYCoordinate() - voice.getHeight();
79-
float yBottom = voice.getYCoordinate() + voice.getHeight();
77+
float yTop = voice.getYCoordinate() + voice.getHeight();
78+
float yBottom = voice.getYCoordinate() - voice.getHeight();
8079

81-
return clickX >= xLeft && clickX <= xRight && clickY >= yTop && clickY <= yBottom;
80+
return clickX >= xLeft && clickX <= xRight && clickY <= yTop && clickY >= yBottom;
8281
}
8382

8483
@Transactional(readOnly = true)

0 commit comments

Comments
 (0)