Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide title bar in MacOS #922

Open
krinkuto11 opened this issue Oct 24, 2024 · 3 comments
Open

Hide title bar in MacOS #922

krinkuto11 opened this issue Oct 24, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@krinkuto11
Copy link

Is your feature request related to a problem? Please describe.
Bazecor stands out (in a bad way) due to the title bar being present in the app

Describe the solution you'd like
I'd suggest the deletion of the title bar, fusing the close, minimize and maximize buttons with the rest of the app

Describe alternatives you've considered
Something like this picture:
Screenshot 2024-10-24 at 12 53 26

Additional context
N/A

@krinkuto11 krinkuto11 added the enhancement New feature or request label Oct 24, 2024
@MiquelDygma
Copy link

MiquelDygma commented Oct 25, 2024

Thank you for the suggestion! As a Mac user, I can't agree more 😅

We'll add it to the backlog and explore how to implement it 😊

@lbrooks
Copy link
Contributor

lbrooks commented Nov 3, 2024

Just for some implementation notes (I only have Mac, so I can't fully test this)

The change to make like the image would be to add titleBarStyle: "hidden", to the creation of the BrowserWindow.

That however makes the window very difficult to move (as there is no longer any title bar). The fix for that is to style an web element with the style -webkit-app-region: "drag" to indicate that it should be able to be used to move the window.

Usability wise, it would probably be easiest to add an extra space at the top of the main window (around the <div className="main-container">) that could be used as a drag handle instead.

Hope that provides enough information for someone that's able to test this change under all the necessary environments.

@MiquelDygma
Copy link

Thank you!

I've talked to the devs, and it looks like it's a fairly easy implementation, although it's a medium priority in the backlog since it's a small quality-of-life improvement.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants