Skip to content

Steps in finalize get skipped even if skipping a step in run phase fails #390

@adamruzicka

Description

@adamruzicka
class MyAction < Dynflow::Action
  def run(event = nil)
    raise "Halt"
  end

  def finalize
  end
end

Steps to reproduce:

  1. Plan the action above
  2. Once it gets stuck, go into dynflow console and try to skip the run step
  3. Click resume

Actual results:
Between steps 2 and 3, the run step turns over to skipping, the finalize step turns over to skipped. After 3, the run step goes back to error. Trying to skip it again leads to invalid transition skipped > skipped error for the finalize step.

Expected results:
Skipped steps are already ignored when skipping or finalize steps being skipped after run steps are really skipped.

Notes:
When auto rescue is enabled, it kinda does steps 2 and 3 for you behind the scenes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions