Skip to content

Commit f0b2b26

Browse files
committed
fix: firstOrNull { it != null }로 변경
filterNotNull().firstOrNull()은 리스트 전체를 순회하여 새로운 리스트를 만든 후 첫 번째 원소를 찾습니다. firstOrNull { it != null }을 사용하면 null이 아닌 첫 번째 원소를 찾는 즉시 순회를 멈추므로 더 효율적입니다.
1 parent 18ca7ec commit f0b2b26

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

app/src/main/java/com/eatssu/android/data/remote/dto/response/MealReviewListResponse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ fun MealReviewListResponse?.toDomain(): List<Review> {
4949
rating = data.rating ?: 0,
5050
writeDate = data.writtenAt ?: "",
5151
content = data.content ?: "",
52-
imgUrl = data.imageUrls.filterNotNull().firstOrNull(),
52+
imgUrl = data.imageUrls.firstOrNull { it != null },
5353
)
5454
} ?: emptyList()
5555
}

app/src/main/java/com/eatssu/android/data/remote/dto/response/MenuReviewListResponse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ fun MenuReviewListResponse?.toDomain(): List<Review> {
4747
rating = data.rating ?: 0,
4848
writeDate = data.writtenAt ?: "",
4949
content = data.content ?: "",
50-
imgUrl = data.imageUrls.filterNotNull().firstOrNull(),
50+
imgUrl = data.imageUrls.firstOrNull { it != null },
5151
)
5252
} ?: emptyList()
5353
}

app/src/main/java/com/eatssu/android/data/remote/dto/response/MyReviewListResponse.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ fun MyReviewListResponse?.toDomain(): List<Review> {
4545
rating = data.rating ?: 0,
4646
writeDate = data.writtenAt ?: "",
4747
content = data.content ?: "",
48-
imgUrl = data.imageUrls.filterNotNull().firstOrNull(),
48+
imgUrl = data.imageUrls.firstOrNull { it != null },
4949
)
5050
} ?: emptyList()
5151
}

0 commit comments

Comments
 (0)