fix: 단일 메뉴 리뷰 작성 시 menuLike null 방지 (#504)

* fix: 단일 메뉴 리뷰 작성 시 menuLike null 방지

* chore: Hilt 버전 업그레이드

Kotlin 메타데이터 버전 불일치로 빌드 불가 문제를 해결하기 위함

* chore: @Inject 필드를 protected → public으로 변경하여 Hilt DI 주입 실패 해결

* Update app/src/main/java/com/eatssu/android/data/remote/repository/ReviewRepositoryImpl.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

Author: HI-JIN2

app/src/main/java/com/eatssu/android/data/remote/repository/ReviewRepositoryImpl.kt

@@ -51,6 +51,7 @@ class ReviewRepositoryImpl @Inject constructor(private val reviewService: Review
     }
 
     override suspend fun writeMenuReview(
+        menuId: Long,
         rating: Int,
         content: String,
         imageUrls: List<String>,
@@ -61,12 +62,10 @@ class ReviewRepositoryImpl @Inject constructor(private val reviewService: Review
             rating = rating,
             content = content,
             imageUrls = imageUrls,
-            menuLike = likeMenuIdList?.firstOrNull()?.let {
-                WriteMenuReviewRequest.MenuLike(
-                    menuId = it,
-                    isLike = true,
-                )
-            }
+            menuLike = WriteMenuReviewRequest.MenuLike(
+                menuId = menuId,
+                isLike = likeMenuIdList?.contains(menuId) ?: false,
+            ),
         )
         return reviewService.writeMenuReview(request).isSuccess()
     }

app/src/main/java/com/eatssu/android/domain/repository/ReviewRepository.kt

@@ -18,6 +18,7 @@ interface ReviewRepository {
     ): Boolean
 
     suspend fun writeMenuReview(
+        menuId: Long,
         rating: Int,
         content: String,
         imageUrls: List<String>,

app/src/main/java/com/eatssu/android/domain/usecase/review/WriteReviewUseCase.kt

@@ -18,6 +18,7 @@ class WriteReviewUseCase @Inject constructor(
         when (menuType) {
             MenuType.FIXED -> {
                 return reviewRepository.writeMenuReview(
+                    menuId = itemId,
                     rating = rating,
                     content = content,
                     imageUrls = if (imageUrl != null) listOf(imageUrl) else emptyList(),

app/src/main/java/com/eatssu/android/presentation/base/BaseActivity.kt

@@ -36,7 +36,7 @@ abstract class BaseActivity<B : ViewBinding>(
 ) : AppCompatActivity() {
 
     @Inject
-    protected lateinit var analyticsTracker: AnalyticsTracker
+    lateinit var analyticsTracker: AnalyticsTracker
 
     private var _binding: B? = null
     val binding get() = _binding!!

app/src/main/java/com/eatssu/android/presentation/base/BaseFragment.kt

@@ -17,7 +17,7 @@ abstract class BaseFragment<B : ViewBinding>(
 ) : Fragment() {
 
     @Inject
-    protected lateinit var analyticsTracker: AnalyticsTracker
+    lateinit var analyticsTracker: AnalyticsTracker
 
     private var _binding: B? = null
     val binding get() = _binding!!

app/src/test/java/com/eatssu/android/data/remote/repository/ReviewRepositoryImplBehaviorSpec.kt

@@ -91,9 +91,10 @@ class ReviewRepositoryImplBehaviorSpec : AppBehaviorSpec({
             val requestSlot = slot<WriteMenuReviewRequest>()
             coEvery { service.writeMenuReview(capture(requestSlot)) } returns ApiResult.Success(Unit)
 
-            then("첫 번째 likeMenuId만 menuLike로 매핑한다") {
+            then("menuId와 isLike를 menuLike로 전달한다") {
                 runTest {
                     repository.writeMenuReview(
+                        menuId = 9L,
                         rating = 3,
                         content = "메뉴리뷰",
                         imageUrls = listOf("img"),
@@ -114,15 +115,19 @@ class ReviewRepositoryImplBehaviorSpec : AppBehaviorSpec({
             val requestSlot = slot<WriteMenuReviewRequest>()
             coEvery { service.writeMenuReview(capture(requestSlot)) } returns ApiResult.Success(Unit)
 
-            then("menuLike=null로 전달한다") {
+            then("menuLike.isLike=false로 전달한다") {
                 runTest {
                     repository.writeMenuReview(
+                        menuId = 1L,
                         rating = 2,
                         content = "x",
                         imageUrls = emptyList(),
                         likeMenuIdList = null,
                     )
-                    requestSlot.captured.menuLike shouldBe null
+                    requestSlot.captured.menuLike shouldBe WriteMenuReviewRequest.MenuLike(
+                        menuId = 1L,
+                        isLike = false,
+                    )
                 }
             }
         }
@@ -131,16 +136,20 @@ class ReviewRepositoryImplBehaviorSpec : AppBehaviorSpec({
             val requestSlot = slot<WriteMenuReviewRequest>()
             coEvery { service.writeMenuReview(capture(requestSlot)) } returns ApiResult.Success(Unit)
 
-            then("menuLike=null로 전달하고 정상 처리한다") {
+            then("menuLike.isLike=false로 전달하고 정상 처리한다") {
                 runTest {
                     repository.writeMenuReview(
+                        menuId = 1L,
                         rating = 1,
                         content = "x",
                         imageUrls = emptyList(),
                         likeMenuIdList = emptyList(),
                     ) shouldBe true
 
-                    requestSlot.captured.menuLike shouldBe null
+                    requestSlot.captured.menuLike shouldBe WriteMenuReviewRequest.MenuLike(
+                        menuId = 1L,
+                        isLike = false,
+                    )
                 }
             }
         }

app/src/test/java/com/eatssu/android/domain/usecase/review/WriteReviewUseCaseBehaviorSpec.kt

@@ -20,6 +20,7 @@ class WriteReviewUseCaseBehaviorSpec : AppBehaviorSpec({
         `when`("FIXED 메뉴에 이미지 없이 작성하면") {
             coEvery {
                 reviewRepository.writeMenuReview(
+                    menuId = 100L,
                     rating = 5,
                     content = "good",
                     imageUrls = emptyList(),
@@ -40,6 +41,7 @@ class WriteReviewUseCaseBehaviorSpec : AppBehaviorSpec({
 
                     coVerify(exactly = 1) {
                         reviewRepository.writeMenuReview(
+                            menuId = 100L,
                             rating = 5,
                             content = "good",
                             imageUrls = emptyList(),
@@ -53,6 +55,7 @@ class WriteReviewUseCaseBehaviorSpec : AppBehaviorSpec({
         `when`("FIXED 메뉴에 이미지가 있으면") {
             coEvery {
                 reviewRepository.writeMenuReview(
+                    menuId = 100L,
                     rating = 4,
                     content = "",
                     imageUrls = listOf("https://img"),

gradle/libs.versions.toml

@@ -44,7 +44,7 @@ compressor = "3.0.1"
 coroutines = "1.7.3"
 kakao-login = "2.23.0"
 kakao-talk = "2.23.0"
-hilt = "2.50"
+hilt = "2.52"
 androidxHilt = "1.2.0"
 play-services-base = "18.0.1"
 firebase-bom = "32.6.0"