diff --git a/src/main/java/uk/ac/ebi/eva/contigalias/datasource/ENAAssemblyDataSource.java b/src/main/java/uk/ac/ebi/eva/contigalias/datasource/ENAAssemblyDataSource.java index d55ee36f..e05fdcfb 100644 --- a/src/main/java/uk/ac/ebi/eva/contigalias/datasource/ENAAssemblyDataSource.java +++ b/src/main/java/uk/ac/ebi/eva/contigalias/datasource/ENAAssemblyDataSource.java @@ -28,7 +28,6 @@ import uk.ac.ebi.eva.contigalias.entities.ChromosomeEntity; import uk.ac.ebi.eva.contigalias.entities.ScaffoldEntity; import uk.ac.ebi.eva.contigalias.entities.SequenceEntity; -import uk.ac.ebi.eva.contigalias.service.AssemblyService; import java.io.IOException; import java.io.InputStream; @@ -70,7 +69,11 @@ public Optional getAssemblyByAccession(String accession) throws ENAAssemblyReportReader reader = readerFactory.build(stream); assemblyEntity = reader.getAssemblyEntity(); } finally { - enaBrowser.disconnect(); + try { + enaBrowser.disconnect(); + } catch (IOException e){ + logger.warn("Error while trying to disconnect - enaBrowser (assembly: " + accession + ") : " + e); + } } return Optional.of(assemblyEntity); } diff --git a/src/main/java/uk/ac/ebi/eva/contigalias/datasource/NCBIAssemblyDataSource.java b/src/main/java/uk/ac/ebi/eva/contigalias/datasource/NCBIAssemblyDataSource.java index 3f1d450b..2d8a3124 100644 --- a/src/main/java/uk/ac/ebi/eva/contigalias/datasource/NCBIAssemblyDataSource.java +++ b/src/main/java/uk/ac/ebi/eva/contigalias/datasource/NCBIAssemblyDataSource.java @@ -16,6 +16,8 @@ package uk.ac.ebi.eva.contigalias.datasource; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Repository; @@ -32,6 +34,8 @@ @Repository("NCBIDataSource") public class NCBIAssemblyDataSource implements AssemblyDataSource { + private final Logger logger = LoggerFactory.getLogger(NCBIAssemblyDataSource.class); + private final NCBIBrowserFactory factory; private final NCBIAssemblyReportReaderFactory readerFactory; @@ -57,7 +61,11 @@ public Optional getAssemblyByAccession( NCBIAssemblyReportReader reader = readerFactory.build(stream); assemblyEntity = reader.getAssemblyEntity(); } finally { - ncbiBrowser.disconnect(); + try { + ncbiBrowser.disconnect(); + } catch (IOException e) { + logger.warn("Error while trying to disconnect - ncbiBrowser (assembly: " + accession + ") : " + e); + } } return Optional.of(assemblyEntity); } diff --git a/src/main/java/uk/ac/ebi/eva/contigalias/dus/PassiveAnonymousFTPClient.java b/src/main/java/uk/ac/ebi/eva/contigalias/dus/PassiveAnonymousFTPClient.java index e24f60f6..ba4f2f9f 100644 --- a/src/main/java/uk/ac/ebi/eva/contigalias/dus/PassiveAnonymousFTPClient.java +++ b/src/main/java/uk/ac/ebi/eva/contigalias/dus/PassiveAnonymousFTPClient.java @@ -60,7 +60,11 @@ public void connect(String address, int port) throws IOException { logger.info("Connected successfully to {}", address); } catch (Exception e) { logger.error("Could not connect to FTP server '{}'. {}.", address, getStatusString()); - this.disconnect(); + try { + this.disconnect(); + } catch (IOException ex) { + logger.warn("Error while trying to disconnect : " + ex); + } throw e; } }