-
Notifications
You must be signed in to change notification settings - Fork 218
[WIP] Add support for electron impact ionization in binary collisions (DSMC module) #5524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
…nto ionization_dsmc_ci
for more information, see https://pre-commit.ci
5 tasks
3 tasks
This PR has been incorporated into #5654, so I'll close this one. |
RemiLehe
added a commit
that referenced
this pull request
Mar 4, 2025
This PR extends the work already done by @RemiLehe and @oshapoval in #5524. Some changes were made to how the ionization process is initialized, for example, the user must now specify the `target_species` (i.e., the species which undergoes ionization) as well as the `product_species`. The product species can include the colliding species (for example electron + neutral -> 2 x electron + ion), but does not have to (for example H$^+$ + D -> H$^+$ + D$^+$ + electron). The test created by @archermarx is now passing (at least early on):  Todo: - [x] test implementation - [x] fix scattering process to conserve momentum - [x] clean up code --------- Signed-off-by: roelof-groenewald <[email protected]> Co-authored-by: Remi Lehe <[email protected]> Co-authored-by: Olga Shapoval <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Description edited by @RemiLehe *
This adds support for electron impact ionization, within the DSMC module.
Note: could we do binary charge exchange in the same way?
TODO: