Kokkos 5.0 does not support custom View layouts needed for AoSoA

[JStewart28]

When installing Cabana with Spack using Kokkos 5.0, the following error is generated:

1 error found in build log:
     16    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD
     17    -- Performing Test CMAKE_HAVE_LIBC_PTHREAD - Success
     18    -- Found Threads: TRUE
     19    -- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS
     20    -- Performing Test HIP_CLANG_SUPPORTS_PARALLEL_JOBS - Success
     21    -- Enabled Kokkos devices: SERIAL;HIP
  >> 22    CMake Error at CMakeLists.txt:46 (message):
     23    Current Kokkos does not support custom View layouts needed for
             AoSoA unless Kokkos is built with Kokkos_ENABLE_IMPL_VIEW_LEGACY=ON.
     25

[streeve]

I'll put in a quick MR to support this on the spack side - thanks for pointing this out

[nibblelab]

Hi,

I have the same problem but using CUDA 13 and Kokkos 5 (from Trilinos 17.0.0). Is there any estimated date for this update?

[jngrad]

I have a similar issue on Fedora, where the kokkos-devel package was recently updated to 5.0.2 and is now built without IMPL_VIEW_LEGACY: https://bugzilla.redhat.com/show_bug.cgi?id=2463734#c2

The Bugzilla ticket is about the 4.7 version missing, and rebuilding against 5.0.2 is not possible due to:

/home/user/espresso-5.0.0/build/_deps/cabana-src/core/src/Cabana_AoSoA.hpp:119:40: error:
  ‘MemoryManaged’ in namespace ‘Kokkos’ does not name a type; did you mean ‘MemoryUnmanaged’?
  119 |           class MemoryTraits = Kokkos::MemoryManaged>
      |                                        ^~~~~~~~~~~~~
      |                                        MemoryUnmanaged
/home/user/espresso-5.0.0/build/_deps/cabana-src/core/src/Cabana_AoSoA.hpp:128:78: error:
  template argument 4 is invalid [-Wtemplate-body]
  128 |     using host_mirror_type = AoSoA<DataTypes, Kokkos::HostSpace, VectorLength>;
      |                                                                              ^

and

/home/user/espresso-5.0.0/build/_deps/cabana-src/core/src/Cabana_ParticleList.hpp:188:78: error:
  template argument 4 is invalid [-Wtemplate-body]
  188 |     using aosoa_type = Cabana::AoSoA<member_types, memory_space, VectorLength>;
      |                                                                              ^
/home/user/espresso-5.0.0/build/_deps/cabana-src/core/src/Cabana_ParticleList.hpp:188:24: error:
  expected type-specifier [-Wtemplate-body]
  188 |     using aosoa_type = Cabana::AoSoA<member_types, memory_space, VectorLength>;
      |                        ^~~~~~
/home/user/espresso-5.0.0/build/_deps/cabana-src/core/src/Cabana_ParticleList.hpp:190:33: error:
  ‘aosoa_type’ has not been declared [-Wtemplate-body]
  190 |     using tuple_type = typename aosoa_type::tuple_type;
      |                                 ^~~~~~~~~~