Skip to content

Commit 170ceea

Browse files
committed
Simplify matrix creation
1 parent 4913ae5 commit 170ceea

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

eitprocessing/roi_selection/gridselection.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -152,10 +152,9 @@ def find_grid(self, data) -> list[NDArray]:
152152
for vertical, horizontal in itertools.product(
153153
vertical_grouping_vectors, horizontal_grouping_vectors
154154
):
155-
matrix = np.ones(data.shape)
155+
# [None, :] converts to row vector, [:, None] converts to column vector
156+
matrix = vertical[:, None] @ horizontal[None, :]
156157
matrix[np.isnan(data)] = np.nan
157-
matrix *= horizontal
158-
matrix *= vertical[:, None] # [:, None] converts to a column vector
159158
matrices.append(matrix)
160159

161160
return matrices

0 commit comments

Comments
 (0)