Skip to content

Commit 1a1183c

Browse files
PoolingClientConnectionManager is deprecated in the referenced version of httpclient, but apparently its replacement (PoolingHttpClientConnectionManager) has different behavior that breaks our usage, so we have to continue using the deprecated class for now (#17)
1 parent 2789a51 commit 1a1183c

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

src/main/java/com/emc/rest/smart/SmartClientFactory.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,9 @@ static ApacheHttpClient4Handler createApacheClientHandler(SmartConfig smartConfi
147147
ClientConfig clientConfig = new DefaultClientConfig();
148148

149149
// set up multi-threaded connection pool
150-
org.apache.http.impl.conn.PoolingHttpClientConnectionManager connectionManager = new org.apache.http.impl.conn.PoolingHttpClientConnectionManager();
150+
// TODO: find a non-deprecated connection manager that works (swapping out with
151+
// PoolingHttpClientConnectionManager will break threading)
152+
org.apache.http.impl.conn.PoolingClientConnectionManager connectionManager = new org.apache.http.impl.conn.PoolingClientConnectionManager();
151153
// 999 maximum active connections (max allowed)
152154
connectionManager.setDefaultMaxPerRoute(999);
153155
connectionManager.setMaxTotal(999);

0 commit comments

Comments
 (0)