Single buffer for as solves

Author: filikat

highs/ipm/hipo/ipm/FactorHighsSolver.cpp

@@ -134,20 +134,20 @@ Int FactorHighsSolver::solveAS(const std::vector<double>& rhs_x,
 
   Int n = rhs_x.size();
 
-  std::vector<double> rhs;
-  rhs.insert(rhs.end(), rhs_x.begin(), rhs_x.end());
-  rhs.insert(rhs.end(), rhs_y.begin(), rhs_y.end());
+  as_buffer_.resize(rhs_x.size() + rhs_y.size());
+  std::copy(rhs_x.begin(), rhs_x.end(), as_buffer_.begin());
+  std::copy(rhs_y.begin(), rhs_y.end(), as_buffer_.begin() + n);
 
   Clock clock;
-  if (FH_.solve(rhs.data())) return kErrorSolve;
+  if (FH_.solve(as_buffer_.data())) return kErrorSolve;
 
   info_.solve_time += clock.stop();
   info_.solve_number++;
 
   data_.back().num_solves++;
 
-  lhs_x = std::vector<double>(rhs.begin(), rhs.begin() + n);
-  lhs_y = std::vector<double>(rhs.begin() + n, rhs.end());
+  lhs_x.assign(as_buffer_.begin(), as_buffer_.begin() + n);
+  lhs_y.assign(as_buffer_.begin() + n, as_buffer_.end());
 
   return kOk;
 }

highs/ipm/hipo/ipm/FactorHighsSolver.h

@@ -16,16 +16,16 @@ namespace hipo {
 
 class FactorHighsSolver : public LinearSolver {
   FHsolver FH_;
-
   KktMatrix& kkt_;
-
   const Regularisation& regul_;
   Info& info_;
   IpmData& data_;
   const Logger& logger_;
   const Model& model_;
   Options& options_;
 
+  std::vector<double> as_buffer_;
+
   std::string ordering_AS_ = "none";
   std::string ordering_NE_ = "none";
 

highs/ipm/hipo/ipm/UpLookingSolver.cpp

@@ -249,22 +249,20 @@ Int UpLookingSolver::solveAS(const std::vector<double>& rhs_x,
 
   Int n = rhs_x.size();
 
-  // create single rhs
-  std::vector<double> rhs;
-  rhs.insert(rhs.end(), rhs_x.begin(), rhs_x.end());
-  rhs.insert(rhs.end(), rhs_y.begin(), rhs_y.end());
+  as_buffer_.resize(rhs_x.size() + rhs_y.size());
+  std::copy(rhs_x.begin(), rhs_x.end(), as_buffer_.begin());
+  std::copy(rhs_y.begin(), rhs_y.end(), as_buffer_.begin() + n);
 
   Clock clock;
-  permuteVectorInverse(rhs, kkt_.iperm());
-  solve(rhs);
-  permuteVector(rhs, kkt_.iperm());
+  permuteVectorInverse(as_buffer_, kkt_.iperm());
+  solve(as_buffer_);
+  permuteVector(as_buffer_, kkt_.iperm());
   info_.solve_time += clock.stop();
   info_.solve_number++;
   data_.back().num_solves++;
 
-  // split lhs
-  lhs_x = std::vector<double>(rhs.begin(), rhs.begin() + n);
-  lhs_y = std::vector<double>(rhs.begin() + n, rhs.end());
+  lhs_x.assign(as_buffer_.begin(), as_buffer_.begin() + n);
+  lhs_y.assign(as_buffer_.begin() + n, as_buffer_.end());
 
   return kOk;
 }

highs/ipm/hipo/ipm/UpLookingSolver.h

@@ -35,6 +35,8 @@ class UpLookingSolver : public LinearSolver {
   std::vector<Int> parent_;
   double flops_;
 
+  std::vector<double> as_buffer_;
+
   Info& info_;
   IpmData& data_;
   const Regularisation& regul_;