Skip to content

Commit 7363539

Browse files
committed
Changed how HIPO_USES_OPENBLAS and HIPO_USES_APPLEBLAS are configured, so that it works correctly when using BLAS_LIBRARIES.
Note that when using `BLAS_LIBRARIES`, the version number is not known unless you manually set `OpenBLAS_VERSON="x.x.x"`.
1 parent 1e3d101 commit 7363539

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

cmake/FindHipoDeps.cmake

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,32 +14,32 @@ set(BLAS_ROOT "" CACHE STRING "Root directory of BLAS or OpenBLAS")
1414
function(highs_configure_blas_target)
1515
set(HIGHS_BLAS_TARGET "" PARENT_SCOPE)
1616
set(HIGHS_BLAS_INCLUDE_DIRS "" PARENT_SCOPE)
17-
set(HIGHS_BLAS_COMPILE_DEFINITION "" PARENT_SCOPE)
1817

1918
if(APPLE)
20-
set(HIGHS_BLAS_COMPILE_DEFINITION HIPO_USES_APPLE_BLAS PARENT_SCOPE)
2119
elseif(OpenBLAS_FOUND AND TARGET OpenBLAS::OpenBLAS)
2220
set(HIGHS_BLAS_TARGET OpenBLAS::OpenBLAS PARENT_SCOPE)
23-
set(HIGHS_BLAS_COMPILE_DEFINITION HIPO_USES_OPENBLAS PARENT_SCOPE)
2421
elseif(OPENBLAS_LIB)
2522
set(HIGHS_BLAS_TARGET "${OPENBLAS_LIB}" PARENT_SCOPE)
2623
set(HIGHS_BLAS_INCLUDE_DIRS "${OPENBLAS_INCLUDE_DIR}" PARENT_SCOPE)
27-
set(HIGHS_BLAS_COMPILE_DEFINITION HIPO_USES_OPENBLAS PARENT_SCOPE)
2824
elseif(TARGET BLAS::BLAS)
2925
set(HIGHS_BLAS_TARGET BLAS::BLAS PARENT_SCOPE)
3026
endif()
3127
endfunction()
3228

3329
# set appropriate BLAS dependency licensing metadata
3430
function(highs_configure_blas_metadata)
31+
set(HIGHS_BLAS_COMPILE_DEFINITION "" PARENT_SCOPE)
32+
3533
if(APPLE)
3634
set(HIGHS_BLAS_VENDOR "Apple Accelerate" PARENT_SCOPE)
3735
set(HIGHS_BLAS_VERSION "${CMAKE_OSX_DEPLOYMENT_TARGET}" PARENT_SCOPE)
3836
set(HIGHS_BLAS_LICENSE "Apple SDK license" PARENT_SCOPE)
39-
elseif(OpenBLAS_FOUND OR OPENBLAS_LIB)
37+
set(HIGHS_BLAS_COMPILE_DEFINITION HIPO_USES_APPLE_BLAS PARENT_SCOPE)
38+
elseif(OpenBLAS_FOUND OR OPENBLAS_LIB OR BLA_VENDOR MATCHES "OpenBLAS")
4039
set(HIGHS_BLAS_VENDOR OpenBLAS PARENT_SCOPE)
4140
set(HIGHS_BLAS_VERSION "${OpenBLAS_VERSION}" PARENT_SCOPE)
4241
set(HIGHS_BLAS_LICENSE BSD-3-Clause PARENT_SCOPE)
42+
set(HIGHS_BLAS_COMPILE_DEFINITION HIPO_USES_OPENBLAS PARENT_SCOPE)
4343
elseif(BLA_VENDOR MATCHES "Intel|MKL")
4444
set(HIGHS_BLAS_VENDOR "Intel oneMKL" PARENT_SCOPE)
4545
set(HIGHS_BLAS_VERSION "${MKL_VERSION}" PARENT_SCOPE)
@@ -215,7 +215,6 @@ function(highs_configure_blas)
215215
set(OpenBLAS_FOUND TRUE)
216216
set(HIGHS_BLAS_TARGET ${_openblas_target})
217217
set(HIGHS_BLAS_INCLUDE_DIRS "${CMAKE_BINARY_DIR}/_deps/openblas-src/include")
218-
set(HIGHS_BLAS_COMPILE_DEFINITION HIPO_USES_OPENBLAS)
219218
highs_configure_blas_metadata()
220219

221220
set(HIGHS_BLAS_CONFIGURED TRUE)

0 commit comments

Comments
 (0)