Fix running fates with HIST/SSP compsets.#3812
Open
mvdebolskiy wants to merge 5 commits intoESCOMP:b4b-devfrom
Open
Fix running fates with HIST/SSP compsets.#3812mvdebolskiy wants to merge 5 commits intoESCOMP:b4b-devfrom
mvdebolskiy wants to merge 5 commits intoESCOMP:b4b-devfrom
Conversation
mvdebolskiy
added
bug
slevis-lmwg
requested changes
Mar 12, 2026
Contributor
slevis-lmwg
left a comment
slevis-lmwg
left a comment
There was a problem hiding this comment.
Thanks @mvdebolskiy. I'm requesting a change to an error message.
github-project-automation
bot
moved this to Stalled (needs review, blocked etc.)
in CTSM: Upcoming tags
ekluzek
moved this from Stalled (needs review, blocked etc.)
to In progress - b4b-dev
in CTSM: Upcoming tags
Collaborator
|
I was skeptical that we didn't have irrigate==TRUE. But, @mvdebolskiy did point out why that is guaranteed since the code aborts with an itype error. However, in any case I made sure FATES tests in aux_clm and fates testlists on Derecho didn't set irrigate==TRUE and they don't. So this is something that can come into b4b-dev. Thanks for working on this @mvdebolskiy this will be good to bring in. We should also reference the issue #3130 here. I'll add that to the top. |
…iy/CTSM into bug-fix/irrigate-fates
slevis-lmwg
approved these changes
Mar 18, 2026
github-project-automation
bot
moved this from In progress - b4b-dev
to In progress - master
in CTSM: Upcoming tags
adrifoster
moved this from In progress - master
to In progress - b4b-dev
in CTSM: Upcoming tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Enforce
irrigate=.false.when running with fates.Putting this on bfb, since the fix will not affect the current test-suites.
Specific notes
Since
ctsm5.3.046:patch%itypeis set to -999, which produces out-of-bounds error, when running HIST with fates, since the defaults point toirrigate=.true..Though there is
irrigate=.true.in use_cases, all the statements with.true.value haveuse_crop=.true.which can not be true when fates is on.Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes NorESMhub#204
Works on #3130
Are answers expected to change (and if so in what way)?
No, since there not tests with HIST and FATES in the test-suite.
Any User Interface Changes (namelist or namelist defaults changes)?
irrigate=.false.whenuse_fates=.true..Does this create a need to change or add documentation? Did you do so?
No/No
Testing performed, if any:
Testsuits don't cover this bug, so I ran:
All passed. Irrigate was
.false.,.false.,.truerespectively.NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).