Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change detector_id to det_el_id #47

Open
KrisThielemans opened this issue Nov 1, 2024 · 0 comments
Open

change detector_id to det_el_id #47

KrisThielemans opened this issue Nov 1, 2024 · 0 comments
Assignees
@KrisThielemans

Comments

@KrisThielemans
Copy link
Contributor

If we do keep detector_ids, we should rename them:

I also think that detector_id isn't great, as for many, a whole module could easily be the "detector". The name detecting_element (or det_el) seems to be more appropriate for the lowest level concept.

Originally posted by @KrisThielemans in #35 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrisThielemans KrisThielemans

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@KrisThielemans