About section rebasement #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create `components/shared` folder - Create `Button.astro` in `shared` folder (due this component will be used in multiple pages across our website - Add `Button.astro` in `About.astro`
Due Astro building process, image's relative paths cause some problems, resulting in 404 errors. To fix this, I've relocated photos into `public/images` folder
…`AboutSection.astro` - Renamed `AboutUs.astro` to `AboutSection.astro` (a more descriptive name) - Made AboutSection parametric: replaced hardcoded content with props for title, description, image, and call to action (CTA) - Updated styles according latest design mockup
Used `AboutSection.astro` and data from `home-sections.json` to update 'About Section' implementation
nsandoya
added this to the Milestone: Version 1.1.0 - Community Listing, Event Page, and Homepage Improvements milestone
…omponent flexibility
IvanM9
approved these changes
Jan 21, 2025
davcortez
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new PR introduces some improvements based on latest design mockups:
AboutUs.astrointoAboutSection.astroto create a more rehusable componenthome-sections.jsonwith homepage contentpublic/images(due Astro building process, former filepath caused problems when used it fromhome-sections.json)AboutSection.astro, based on latest mockupsAboutSection.astroparametric: Replaced hardcoded content with props for title, description, image, and call to action (CTA)index.astrowithAboutSection.astroand data fromhome-sections.jsonP.S.: There's a new Explore Events section we need to add (see design references). I'll address this in a follow-up PR
Resolves #34