Model Notes

[koaxheli]

Radiomaster TX16S

The checklist display is [missing] in Companion v2.6.
It was still available in v2.5.

General information
EdgeTX "Santa" 2.6.0-RC2

[pfeerick]

Um... so what is the problem? 😁

[koaxheli]

Radiomaster TX16S

That the checklist display in Companion v2.6. is missing, is not displayed.

[pfeerick]

Thanks... the difference a missing word makes! :)

Right, so with a model named fpv, and model notes named fpv.txt, it seems like simulator is looking for this file... :-O

f_open(E:/Documents/EdgeTX/RadioMaster TX16s/SD Card V2/SOUNDS/en/fpv/name.wav)

although Companion knows perfectly well it is in

I also don't recommend using the sd browser to find that file instead, unless you want simulator and companion to crash.

[elecpower]

Right, so with a model named fpv, and model notes named fpv.txt, it seems like simulator is looking for this file... :-O

f_open(E:/Documents/EdgeTX/RadioMaster TX16s/SD Card V2/SOUNDS/en/fpv/name.wav)

Simulator and radio always look for this file /model name/name.wav as a audio call out on radio boot. I use this feature.

[pfeerick]

Ok, so trying again, and it now goes beyond that - maybe I scrolled back and missed the lines after...

First at around 8 seconds is the attempt to view the model notes via the menu, and then at around 18s trying to view it via sd browser and eventual crash.

FirmwareDebug_22-01-08_21-18-04.zip

[elecpower]

at 18s f_open(E:/Documents/EdgeTX/RadioMaster TX16s/SD Card V2/C:/Users/pfeer/AppData/Local/Temp/etx-CfELgo/MODELS/fpv.txt) = INVALID_NAME (FIL 000000d62f7fedf0)

So combines both directories and appends file name so something definitely wrong with sd browser in simulator mode. Also it should halt after 1st failed attempt.

[elecpower]

From the log, the radio start up doesn't bother to look at the profile sd card for the checklist file. Checklist is displayed on radio start up for B&W radios tested with X9D+ simulator.
There is different logic between deciding whether the Model Notes icon should be shown and actually trying to find and read the checklist file on clicking the icon.

[pfeerick]

There are three ways to look at this at - you can enable the checklist (which I didn't), you can view the model notes directly / via the menu (which I did), or via the sd browser (which I did). If you enable the checklist it doesn't show up. If you attempt to view the model notes it doesn't show up. If you attempt to view the model notes through the sd browser - it stops working ;)

At the end of the day, something is wrong with the path, which is what is setting everything off.

[elecpower]

When the target radios are compiled in simu mode any file access code needs to check both sd paths (primary and if not found then profile).
Depending on how the libsim is started Companion (etx) or Simulator (data file, data folder, sd card) depends on what is in the primary path.
It is not practical to have one merged path, as every file in the profile path would have to be copied to the temp path on every simulator launch (hot beverage time).

[piotrva]

Yup, reading a file using SD browser crashes the sim, and notes are not being displayed.
It gets into infinite loop of opening the file:
93.14s: f_open(/src/build-tx16/SDCARD_SIM/tmp/etx-lDHiie/MODELS/New_model.txt) = INVALID_NAME (FIL 0x7fe21a8c5690) 93.14s: not found
That does not stop even when simulator is closed (or it is just so much terminal data that it keeps going after simulation is disabled...
Do you know if it is a thing on other colorlcd radios? As this stops me for now on preparing #1417 for them...

[pfeerick]

Right, so this is something very specific to the Simulator data file / launch through Companion mode - as if you run Simulator standalone, and instead use the data folder or sd image modes, everything works properly.

[pfeerick]

What I found rather odd was this... when in data file mode, it correctly identified the existence of the file, but then changed into the tempoary unzip directory for ETX data file. btw, if you shove the model notes into that tempoary folder, that works also...

207.54s: f_stat(C:/ETX/SD/MODELS/ParkMaster.txt) = OK
207.54s: [ViewMain] Focus lost
208.40s: [ViewMain] Focus gained
208.40s: f_chdir(C:/Users/pfeer/AppData/Local/Temp/etx-zkwtwq/MODELS)
208.40s: 	not found
208.40s: f_stat(ParkMaster.txt) = error 2 (No such file or directory)
208.40s: 	not found
208.40s: f_stat(ParkMaster.txt) = error 2 (No such file or directory)
208.40s: 	not found
208.40s: f_stat(model1.txt) = error 2 (No such file or directory)
208.40s: 	not found
208.40s: f_stat(model1.txt) = error 2 (No such file or directory)