Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ISO8601 duration formatting #4343

Open
wants to merge 3 commits into
base: next-minor
Choose a base branch
from
Open

Conversation

fubhy
Copy link
Member

@fubhy fubhy commented Jan 26, 2025

Should we add this? If so, I'd add a parser implementation too. The spec isn't clear on how to deal with months and years but I left them out anyways for now which is in line with our existing Duration implementation which also doesn't handle those.

Closes #4319

@fubhy fubhy requested a review from mikearnaldi as a code owner January 26, 2025 12:00
Copy link

changeset-bot bot commented Jan 26, 2025

🦋 Changeset detected

Latest commit: b9d4a6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster-browser Major
@effect/cluster-node Major
@effect/cluster-workflow Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc-http Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/ai Major
@effect/ai-openai Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@fubhy fubhy force-pushed the duration-format-iso branch from 88a9ef1 to 3489bac Compare January 26, 2025 12:06
@effect-bot effect-bot changed the base branch from main to next-minor January 26, 2025 12:06
@effect-bot effect-bot force-pushed the next-minor branch 6 times, most recently from bbe556f to df7f007 Compare January 28, 2025 10:12
@mikearnaldi
Copy link
Member

I can't think of an argument against imho

@fubhy
Copy link
Member Author

fubhy commented Jan 30, 2025

I can't think of an argument against imho

Alright, let's do it then!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Discussion Ongoing
Development

Successfully merging this pull request may close these issues.

Support ISO-8601 format for Duration
3 participants