Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimpleHistory crashes with Ace Stream #143

Open
Lc4B opened this issue Apr 27, 2024 · 9 comments
Open

SimpleHistory crashes with Ace Stream #143

Lc4B opened this issue Apr 27, 2024 · 9 comments

Comments

@Lc4B
Copy link

Lc4B commented Apr 27, 2024

SimpleHistory crashes if I use an acestream:// link and also if I add it to the blacklist

[SimpleHistory] Lua error: D:/.../SimpleHistory.lua:1974: attempt to index a nil value

@thequantumcog
Copy link

I am getting it for every video I play after I upgraded mpv

@thequantumcog
Copy link

Pull request #142 Fixes the problem for me

@Lc4B
Copy link
Author

Lc4B commented Apr 29, 2024

Pull request #142 Fixes the problem for me

for me this also doesn't solve the problem, it always gives me that error on that string with ace stream link

@Eisa01
Copy link
Owner

Eisa01 commented Apr 29, 2024

Is there any acestream sample I can test it on? Never used this protocol before

@Lc4B
Copy link
Author

Lc4B commented Apr 29, 2024

you can find some links on AceStreamID, but you should download the engine and have the mpv script to try them.
the links are like this acestream://0000000000000000000000000000000000000000 and honestly I would be fine even if they are not supported or put them in the blacklist, as long as SimpleHistory doesn't crash

@Eisa01
Copy link
Owner

Eisa01 commented Apr 29, 2024

The crash could be related to different reason based on the log. It seems that your log file has an issue.

Try the latest script from scratch:
Delete or rename the log file if you want to keep it
Path for Windows OS: %APPDATA%\mpv\mpvHistory.log,
Path for Linux OS and MAC OS: ~.config\mpv\mpvHistory.log

Re-download the latest script and config file (not from releases page but from the repository directly)

Let me know how it goes.

@Lc4B
Copy link
Author

Lc4B commented Apr 29, 2024

ok, I already had everything updated but by doing the tests cleanly you can see that the problem comes from the .conf file, as soon as I set anything in history_blacklist, in that case only if I open acestream links the script crashes (not with files or youtube links for example). I'm currently testing it without log file, with the base file and just changing the conf like this:
history_blacklist=[".gif"]
and it crashes, any suggestions?

@Eisa01
Copy link
Owner

Eisa01 commented Apr 29, 2024

When blacklist is not touched, the script crashes or it works fine with acestream?

@Lc4B
Copy link
Author

Lc4B commented Apr 29, 2024

When blacklist is not touched, the script crashes or it works fine with acestream?

works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants