Skip to content

Add x (ex-Twitter) #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add x (ex-Twitter) #162

wants to merge 1 commit into from

Conversation

xfzv
Copy link
Contributor

@xfzv xfzv commented Sep 16, 2024

No description provided.

@hash-dev
Copy link

hash-dev commented Nov 9, 2024

Twitter URLs are still valid URLs. You should add x rather than replace twitter. Also, as long as your work has not been merged, you shouldn't add a commit to fix a mistake you made in a previous commit. Just fix it in the previous commit instead.

@xfzv xfzv changed the title Replace twitter with x Add x (ex-Twitter) Feb 9, 2025
@xfzv
Copy link
Contributor Author

xfzv commented Feb 9, 2025

Twitter URLs are still valid URLs. You should add x rather than replace twitter.

Indeed, you're right. Thanks for pointing out my mistake.

Hopefully it's fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xfzv @hash-dev