Remove assert statements from bignum (#78)

* Remove assert statements from bignum

improve logging around bignum computation

* remove assert.h update max ballot payload

* reset max ballot payload to 2000

* Explicitly break loop on import end of file

add log.h to coordinator

* modify test selections

Author: AddressXception

CMakeLists.txt

@@ -14,6 +14,7 @@ message("Generated with config types: ${CMAKE_CONFIGURATION_TYPES}")
 IF(CMAKE_BUILD_TYPE MATCHES Debug)
     message("setting DEBUG during compile")
     add_compile_definitions(DEBUG)
+    #add_compile_definitions(DEBUG_PRINT)
 ENDIF()
 
 

examples/api/main.c

@@ -48,7 +48,7 @@ static bool result_equals_expected_selections(
 uint32_t const NUM_TRUSTEES = 3;
 uint32_t const THRESHOLD = 2; 
 uint32_t const NUM_ENCRYPTERS = 3;
-uint32_t const NUM_SELECTIONS = 12;                  // the number of total contest selections for an election
+uint32_t const NUM_SELECTIONS = 3;                  // the number of total contest selections for an election
 uint32_t const DECRYPTING_TRUSTEES = 2;             // must be >= THRESHOLD && <= NUM_TRUSTEES
 uint32_t const NUM_RANDOM_BALLOTS = 5;              // the number of ballots to use when executing the test
 
@@ -74,16 +74,20 @@ int main()
 
     struct trustee_state trustee_states[MAX_TRUSTEES];
     ok = API_CreateElection(&config, trustee_states);
+    if (!ok) printf("Create Election Failed!");
 
     for (uint32_t i = 0; i < NUM_TRUSTEES && ok; i++)
     {
         if (trustee_states[i].bytes == NULL)
+        {
+            printf("trustee_state %d is NULL - FAIL!", i);
             ok = false;
+        }
     }
 
     // Encrypt Ballots
 
-    printf("\n--- Encrypt Ballots ---\n\n");
+    if (ok) printf("\n--- Encrypt Ballots ---\n\n");
 
     struct register_ballot_message memory_encrypted_ballots[NUM_RANDOM_BALLOTS];
     struct test_ballot testBallots[NUM_RANDOM_BALLOTS];
@@ -105,6 +109,7 @@ int main()
 
     if (ok)
     {
+        printf("Soft Deleting existing file\n");
         ok = API_EncryptBallot_soft_delete_file(encrypted_output_path, encrypted_output_prefix);
 
         for (uint32_t i = 0; i < NUM_RANDOM_BALLOTS && ok; i++)
@@ -154,7 +159,7 @@ int main()
     // and pass it to the tally functions, but this is not strictly necessary
     // from an API Perspective.
 
-    printf("\n--- Load Ballots ---\n\n");
+    if (ok) printf("\n--- Load Ballots ---\n\n");
 
     // load the ballot ID's so we can cast/spoil them
     char *loaded_external_identifiers[NUM_RANDOM_BALLOTS];
@@ -166,7 +171,7 @@ int main()
     {
         ok = API_LoadBallots(
             0, 
-            NUM_RANDOM_BALLOTS, 
+            MAX_BALLOT_PAYLOAD, 
             NUM_SELECTIONS, 
             encrypted_ballots_filename, 
             loaded_external_identifiers,
@@ -207,7 +212,7 @@ int main()
 
     // Register & Record Cast/Spoil Multiple Ballots
 
-    printf("\n\n--- Randomly Assigning Ballots to be Cast or Spoil Arrays ---\n\n");
+    if (ok) printf("\n\n--- Randomly Assigning Ballots to be Cast or Spoil Arrays ---\n\n");
 
     uint32_t current_cast_index = 0;
     uint32_t current_spoiled_index = 0;
@@ -244,7 +249,7 @@ int main()
         ok = false;
     }
 
-    printf("\n--- Record Ballots (Register, Cast, and Spoil) ---\n\n");
+    if (ok) printf("\n--- Record Ballots (Register, Cast, and Spoil) ---\n\n");
 
     char *cast_and_spoiled_ballots_filename = NULL;
     char *casted_trackers[current_cast_index];
@@ -298,7 +303,7 @@ int main()
 
     // Tally Votes & Decrypt Results
 
-    printf("\n--- Tally & Decrypt Votes ---\n\n");
+    if (ok) printf("\n--- Tally & Decrypt Votes ---\n\n");
 
     char *tally_filename = NULL;
     uint32_t tally_results[config.num_selections];
@@ -369,7 +374,15 @@ int main()
 
     API_CreateElection_free(config.joint_key, trustee_states);
 
-    printf("\n--- Done! ---\n\n");
+    if (ok)
+    {
+        printf("\n--- Done! ---\n\n");
+    } 
+    else
+    {
+        printf("\n--- FAILED! ---\n\n");
+    }
+    
 
     if (ok)
         return EXIT_SUCCESS;

include/electionguard/keyceremony/trustee.h

@@ -21,6 +21,7 @@ enum KeyCeremony_Trustee_status
     KEYCEREMONY_TRUSTEE_INVALID_KEY_SHARE,
     KEYCEREMONY_TRUSTEE_SERIALIZE_ERROR,
     KEYCEREMONY_TRUSTEE_DESERIALIZE_ERROR,
+    KEYCEREMONY_TRUSTEE_IO_ERROR
 };
 
 /************************** INITIALIZATION & FREEING ***************************/

src/electionguard/api/create_election.c

@@ -2,6 +2,7 @@
 #include <string.h>
 
 #include <electionguard/api/create_election.h>
+#include <log.h>
 
 #include "api/base_hash.h"
 
@@ -33,32 +34,37 @@ static KeyCeremony_Trustee trustees[MAX_TRUSTEES];
 bool API_CreateElection(struct api_config *config,
                         struct trustee_state *trustee_states)
 {
-#ifdef DEBUG_PRINT
-    printf("API_CreateElection::Config:\n\tnum_trustees: %d\n\tthreshold: %d\n\tsubgroup_order: %d\n\telection_meta: %s\n",
-            config->num_trustees, config->threshold, config->subgroup_order, config->election_meta);
-#endif
+    DEBUG_PRINT(("API_CreateElection::Config:\n\tnum_trustees: %d\n\tthreshold: %d\n\tsubgroup_order: %d\n\telection_meta: %s\n",
+            config->num_trustees, config->threshold, config->subgroup_order, config->election_meta));
 
     bool ok = true;
 
     // Set global variables
 
     Crypto_parameters_new();
     api_config = *config;
+    DEBUG_PRINT(("\nCreateElection: Create Base Hash\n"));
     create_base_hash_code(api_config);
 
     // Initialize
 
     if (ok)
         ok = initialize_coordinator();
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: initialize_coordinator - FAILED!\n"));
+
     if (ok)
         ok = initialize_trustees();
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: initialize_trustees - FAILED!\n"));
+
     // Key Ceremony
 
     if (ok)
         ok = generate_keys();
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: generate_keys - FAILED!\n"));
+
     struct all_keys_received_message all_keys_received = {.bytes = NULL};
 
     if (ok)
@@ -68,11 +74,15 @@ bool API_CreateElection(struct api_config *config,
             ok = false;
     }
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: receive_keys - FAILED!\n"));
+
     // Share Generation
 
     if (ok)
         ok = generate_shares(all_keys_received);
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: generate_shares - FAILED!\n"));
+
     struct all_shares_received_message all_shares_received = {.bytes = NULL};
 
     if (ok)
@@ -82,11 +92,15 @@ bool API_CreateElection(struct api_config *config,
             ok = false;
     }
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: receive_shares - FAILED!\n"));
+
     // Verification
 
     if (ok)
         ok = verify_shares(all_shares_received);
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: verify_shares - FAILED!\n"));
+
     // Publish joint key
 
     if (ok)
@@ -96,11 +110,15 @@ bool API_CreateElection(struct api_config *config,
             ok = false;
     }
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: publish_joint_key - FAILED!\n"));
+
     // Export trustee state
 
     if (ok)
         ok = export_trustee_states(trustee_states);
 
+    if (!ok) DEBUG_PRINT(("\nCreateElection: export_trustee_states - FAILED!\n"));
+
     // Cleanup
 
     if (all_shares_received.bytes != NULL)
@@ -193,12 +211,13 @@ bool generate_keys(void)
     for (uint32_t i = 0; i < api_config.num_trustees && ok; i++)
     {
         struct key_generated_message key_generated = {.bytes = NULL};
-
         struct KeyCeremony_Trustee_generate_key_r result =
             KeyCeremony_Trustee_generate_key(trustees[i], base_hash_code);
 
         if (result.status != KEYCEREMONY_TRUSTEE_SUCCESS)
+        {
             ok = false;
+        }
         else
             key_generated = result.message;
 
@@ -210,7 +229,9 @@ bool generate_keys(void)
                     key_generated
                 );
             if (status != KEYCEREMONY_COORDINATOR_SUCCESS)
-                ok = false;            
+            {
+                ok = false;
+            }        
         }
 
         if (key_generated.bytes != NULL)

src/electionguard/api/load_ballots.c

@@ -143,6 +143,7 @@ API_LoadBallots_status load_ballots(uint64_t start_index,
         case VOTING_COORDINATOR_INSUFFICIENT_MEMORY:
             return API_LOADBALLOTS_INSUFFICIENT_MEMORY;
         // TODO: other cases
+        case VOTING_COORDINATOR_END_OF_FILE:
         case VOTING_COORDINATOR_SUCCESS:
         default:
             return API_LOADBALLOTS_SUCCESS;