Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ClassifierOutput's 'prediction' has incorrect type #46

Open
hijohnnylin opened this issue Jan 16, 2025 · 0 comments
Open

[Bug]: ClassifierOutput's 'prediction' has incorrect type #46

hijohnnylin opened this issue Jan 16, 2025 · 0 comments

Comments

@hijohnnylin
Copy link
Contributor

The ClassifierOutput's prediction type shows bool, but when it is used, it's assigned an int of either -1, 0, or 1. The -1 case I think means that there was some error in predicting.

We should decide on:

  1. Make it a bool or not
  2. What to do with the error case (consider it false? maybe create a specific type with 3 states?)

Would be good for the solution to be somewhat backward compatible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant