Solve doc for no-service

Author: EmmanuelDemey

docs/no-services.md

@@ -34,45 +34,45 @@ The following patterns are **not** considered problems with default config;
         // ...
     });
 
-The following patterns are considered problems when configured `["$http","$q"]`:
+The following patterns are considered problems when configured `["http","q"]`:
 
-    /*eslint angular/no-services: [2,["$http","$q"]]*/
+    /*eslint angular/no-services: [2,["http","q"]]*/
 
     // invalid
     app.directive('helloWorld', function($q) {
         // ...
     }); // error: REST API calls should be implemented in a specific service ($q in directive)
 
-The following patterns are **not** considered problems when configured `["$http","$q"]`:
+The following patterns are **not** considered problems when configured `["http","q"]`:
 
-    /*eslint angular/no-services: [2,["$http","$q"]]*/
+    /*eslint angular/no-services: [2,["http","q"]]*/
 
     // valid
     app.directive('helloWorld', function($resource) {
         // ...
     });
 
-The following patterns are considered problems when configured `["$http","$q"]` and `["directive"]`:
+The following patterns are considered problems when configured `["http","q"]` and `["directive"]`:
 
-    /*eslint angular/no-services: [2,["$http","$q"],["directive"]]*/
+    /*eslint angular/no-services: [2,["http","q"],["directive"]]*/
 
     // invalid
     app.directive('MyController', function($http) {
         // ...
     }); // error: REST API calls should be implemented in a specific service ($http in directive)
 
-The following patterns are **not** considered problems when configured `["$http","$q"]` and `["directive"]`:
+The following patterns are **not** considered problems when configured `["http","q"]` and `["directive"]`:
 
-    /*eslint angular/no-services: [2,["$http","$q"],["directive"]]*/
+    /*eslint angular/no-services: [2,["http","q"],["directive"]]*/
 
     // valid
     app.controller('MyController', function($http) {
         // ...
     });
 
-The following patterns are considered problems when configured `{"directive":["$http","$q"],"controller":["$resource"]}`:
+The following patterns are considered problems when configured `{"directive":["http","q"],"controller":["resource"]}`:
 
-    /*eslint angular/no-services: [2,{"directive":["$http","$q"],"controller":["$resource"]}]*/
+    /*eslint angular/no-services: [2,{"directive":["http","q"],"controller":["resource"]}]*/
 
     // invalid
     app.controller('MyController', function($resource, $log) {
@@ -84,9 +84,9 @@ The following patterns are considered problems when configured `{"directive":["$
         // ...
     }); // error: REST API calls should be implemented in a specific service ($http in directive)
 
-The following patterns are **not** considered problems when configured `{"directive":["$http","$q"],"controller":["$resource"]}`:
+The following patterns are **not** considered problems when configured `{"directive":["http","q"],"controller":["resource"]}`:
 
-    /*eslint angular/no-services: [2,{"directive":["$http","$q"],"controller":["$resource"]}]*/
+    /*eslint angular/no-services: [2,{"directive":["http","q"],"controller":["resource"]}]*/
 
     // valid
     app.controller('MyController', function($http, $q, $log) {

examples/no-services.js

@@ -3,6 +3,7 @@ app.controller('MyController', function(myService) {
     // ...
 });
 
+
 // example - valid: false, errorMessage: "REST API calls should be implemented in a specific service ($http in controller)"
 app.controller('MyController', function($http) {
     // ...
@@ -13,43 +14,43 @@ app.directive('helloWorld', function($resource) {
     // ...
 });
 
-// example - valid: true, options: [["$http","$q"]]
+// example - valid: true, options: [["http","q"]]
 app.directive('helloWorld', function($resource) {
     // ...
 });
 
-// example - valid: false, options: [["$http","$q"]], errorMessage: "REST API calls should be implemented in a specific service ($q in directive)"
+// example - valid: false, options: [["http","q"]], errorMessage: "REST API calls should be implemented in a specific service ($q in directive)"
 app.directive('helloWorld', function($q) {
     // ...
 });
 
-// example - valid: true, options: [["$http","$q"],["directive"]]
+// example - valid: true, options: [["http","q"],["directive"]]
 app.controller('MyController', function($http) {
     // ...
 });
 
-// example - valid: false, options: [["$http","$q"],["directive"]], errorMessage: "REST API calls should be implemented in a specific service ($http in directive)"
+// example - valid: false, options: [["http","q"],["directive"]], errorMessage: "REST API calls should be implemented in a specific service ($http in directive)"
 app.directive('MyController', function($http) {
     // ...
 });
 
 
-// example - valid: true, options: [{"directive":["$http","$q"],"controller":["$resource"]}]
+// example - valid: true, options: [{"directive":["http","q"],"controller":["resource"]}]
 app.controller('MyController', function($http, $q, $log) {
     // ...
 });
 
-// example - valid: true, options: [{"directive":["$http","$q"],"controller":["$resource"]}]
+// example - valid: true, options: [{"directive":["http","q"],"controller":["resource"]}]
 app.directive('helloWorld', function($resource, $log) {
     // ...
 });
 
-// example - valid: false, options: [{"directive":["$http","$q"],"controller":["$resource"]}], errorMessage: "REST API calls should be implemented in a specific service ($resource in controller)"
+// example - valid: false, options: [{"directive":["http","q"],"controller":["resource"]}], errorMessage: "REST API calls should be implemented in a specific service ($resource in controller)"
 app.controller('MyController', function($resource, $log) {
     // ...
 });
 
-// example - valid: false, options: [{"directive":["$http","$q"],"controller":["$resource"]}], errorMessage: "REST API calls should be implemented in a specific service ($http in directive)"
+// example - valid: false, options: [{"directive":["http","q"],"controller":["resource"]}], errorMessage: "REST API calls should be implemented in a specific service ($http in directive)"
 app.directive('helloWorld', function($http, $log) {
     // ...
 });

rules/no-services.js

@@ -38,7 +38,7 @@ module.exports = {
         }
 
         if (context.options[0] === undefined) {
-            badServices = ['/\$http/', '/\$resource/', 'Restangular', '/\$q/', '/\$filter/'];
+            badServices = [/\$http/, /\$resource/, /Restangular/, /\$q/, /\$filter/];
         }
 
         if (isArray(context.options[0])) {
@@ -65,6 +65,7 @@ module.exports = {
         }
 
         function isSetBedService(serviceName, angularObjectName) {
+            console.log(badServices)
             if (map) {
                 return map[angularObjectName].find(object => utils.convertPrefixToRegex(object).test(serviceName));
             }