Merge pull request #151 from Gillespie59/development

0.3.0

Author: EmmanuelDemey

README.md

@@ -93,6 +93,7 @@ We provide also three samples :
 | 'ng_module_name': 0                                          | When you create a new module, its name should start with the parameter you can define in your config object. The second parameter can be a Regexp wrapped in quotes. You can not prefix your modules by "ng" (reserved keyword for AngularJS modules) ("ng_module_name":  [2, "ng"])  [Y127](https://github.com/johnpapa/angular-styleguide#style-y127)|
 | 'ng_module_setter':2                                         | Declare modules without a variable using the setter syntax.[Y021](https://github.com/johnpapa/angular-styleguide#style-y021) |
 | 'ng_no_angular_mock':0                                       | All methods defined in the angular.mock object are also available in the object window. So you can remove angular.mock from your code
+| 'ng_no_cookiestore':2                                        | In Angular 1.4, the $cookieStore service is now deprected. Please use the $cookies service instead|
 | 'ng_no_digest': 2                                            | The scope's $digest() method shouldn't be used. You should prefer the $apply method. |
 | 'ng_no_jquery_angularelement': 2                             | You should not wrap angular.element object into jQuery(), because angular.element already return jQLite element|
 | 'ng_no_private_call': 2                                      | All scope's properties/methods starting with $$ are used internally by AngularJS. You should not use them directly. |

demo/grunt/package.json

@@ -9,7 +9,7 @@
   "author": "emmanueldemey <[email protected]>",
   "license": "MIT",
   "devDependencies": {
-    "eslint": "^0.16.1",
+    "eslint": "1.0.0",
     "eslint-plugin-angular": "file:../../",
     "grunt": "^0.4.5",
     "grunt-eslint": "^7.0.1"

demo/gulp/package.json

@@ -9,7 +9,7 @@
   "author": "emmanueldemey <[email protected]>",
   "license": "MIT",
   "devDependencies": {
-    "eslint": "^0.16.1",
+    "eslint": "1.0.0",
     "eslint-plugin-angular": "file:../../",
     "gulp": "^3.8.11",
     "gulp-eslint": "^0.6.0"

demo/npm/package.json

@@ -4,12 +4,12 @@
   "description": "",
   "main": "index.js",
   "scripts": {
-    "lint": "node_modules/.bin/eslint app/ || true"
+    "lint": "node_modules/.bin/eslint app/"
   },
   "author": "emmanueldemey <[email protected]>",
   "license": "MIT",
   "devDependencies": {
-    "eslint": "^0.16.1",
+    "eslint": "1.0.0",
     "eslint-plugin-angular": "file:../../"
   }
 }

index.js

@@ -23,6 +23,7 @@
                   'ng_module_name': require('./rules/ng_module_name'),
                   'ng_module_setter': require('./rules/ng_module_setter'),
                   'ng_no_angular_mock': require('./rules/ng_no_angular_mock'),
+                  'ng_no_cookiestore': require('./rules/ng_no_cookiestore'),
                   'ng_no_digest': require('./rules/ng_no_digest'),
                   'ng_no_jquery_angularelement': require('./rules/ng_no_jquery_angularelement'),
                   'ng_no_private_call': require('./rules/ng_no_private_call'),
@@ -61,6 +62,7 @@
                   'ng_module_name': 0,
                   'ng_module_setter': 2,
                   'ng_no_angular_mock': 0,
+                  'ng_no_cookiestore': 2,
                   'ng_no_digest': 2,
                   'ng_no_jquery_angularelement': 2,
                   'ng_no_private_call': 2,

package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-angular",
-  "version": "0.2.3",
+  "version": "0.3.0",
   "description": "ESLint rules for AngularJS projects",
   "main": "index.js",
   "repository": {
@@ -14,18 +14,18 @@
   },
   "homepage": "https://github.com/Gillespie59/eslint-plugin-angularjs",
   "devDependencies": {
-    "chai": "^1.10.0",
-    "coveralls": "^2.11.2",
-    "eslint": "^0.13.0",
-    "eslint-tester": "^0.5.0",
-    "gulp": "^3.8.10",
-    "gulp-eslint": "^0.3.0",
-    "gulp-istanbul": "0.6.0",
-    "gulp-mocha": "^2.0.0",
-    "istanbul": "^0.3.5",
-    "mocha": "2.1.0",
-    "shelljs": "^0.3.0",
-    "shelljs-nodecli": "^0.1.1"
+    "chai": "3.2.0",
+    "coveralls": "2.11.3",
+    "eslint": "1.0.0",
+    "eslint-tester": "0.8.2",
+    "gulp": "3.9.0",
+    "gulp-eslint": "1.0.0",
+    "gulp-istanbul": "0.10.0",
+    "gulp-mocha": "2.1.3",
+    "istanbul": "0.3.17",
+    "mocha": "2.2.5",
+    "shelljs": "0.5.1",
+    "shelljs-nodecli": "0.1.1"
   },
   "peerDependencies": {
     "eslint": ">=0.8.0"

rules/ng_no_cookiestore.js

@@ -0,0 +1,15 @@
+module.exports = function(context) {
+
+    'use strict';
+
+    return {
+
+        'MemberExpression': function(node) {
+            if(node.object && node.object.name === '$cookieStore'){
+                context.report(node, 'Since Angular 1.4, the $cookieStore service is depreacted. Please use now the $cookies service.', {});
+            }
+
+        }
+    };
+
+};

test/ng_no_cookiestore.js

@@ -0,0 +1,25 @@
+//------------------------------------------------------------------------------
+// Requirements
+//------------------------------------------------------------------------------
+
+var eslint = require('../node_modules/eslint/lib/eslint'),
+    ESLintTester = require('eslint-tester');
+
+//------------------------------------------------------------------------------
+// Tests
+//------------------------------------------------------------------------------
+
+var eslintTester = new ESLintTester(eslint);
+eslintTester.addRuleTest('rules/ng_no_cookiestore', {
+    valid: [
+        '$cookies();'
+    ],
+    invalid: [{
+        code: '$cookieStore.get("");',
+        errors: [{ message: 'Since Angular 1.4, the $cookieStore service is depreacted. Please use now the $cookies service.'}]
+    }, {
+        code: '$cookieStore.put("", "");',
+        errors: [{ message: 'Since Angular 1.4, the $cookieStore service is depreacted. Please use now the $cookies service.'}]
+    }
+    ]
+});