Merge pull request #597 from jfgreffier/fix/449

fix: avoid false positive on function-type rule

Author: EmmanuelDemey

docs/rules/function-type.md

@@ -5,6 +5,7 @@
 Anonymous or named functions inside AngularJS components.
 The first parameter sets which type of function is required and can be 'named' or 'anonymous'.
 The second parameter is an optional list of angular object names.
+The third parameter is an optional list of reserved callee object name, default value is ['_'] to avoid false positive with lodash.
 
 **Rule based on Angular 1.x**
 

rules/function-type.js

@@ -34,6 +34,7 @@ module.exports = {
     },
     create: function(context) {
         var angularObjectList = ['animation', 'config', 'constant', 'controller', 'directive', 'factory', 'filter', 'provider', 'service', 'value', 'decorator'];
+        var reservedNameList = ['_'];
         var configType = context.options[0] || 'named';
         var messageByConfigType = {
             anonymous: 'Use anonymous functions instead of named function',
@@ -45,6 +46,10 @@ module.exports = {
             angularObjectList = context.options[1];
         }
 
+        if (context.options[2]) {
+            reservedNameList = context.options[2];
+        }
+
         function checkType(arg) {
             return utils.isCallExpression(arg) ||
                 (configType === 'named' && (utils.isIdentifierType(arg) || utils.isNamedInlineFunction(arg))) ||
@@ -59,6 +64,10 @@ module.exports = {
                 var firstArgument = node.arguments[1];
 
                 if (utils.isAngularComponent(node) && callee.type === 'MemberExpression' && angularObjectList.indexOf(angularObjectName) >= 0) {
+                    if (reservedNameList.indexOf(callee.object.name) !== -1) {
+                        return;
+                    }
+
                     if (checkType(firstArgument)) {
                         return;
                     }