Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up tests #118

Open
jlouis opened this issue Feb 27, 2014 · 3 comments
Open

Clean up tests #118

jlouis opened this issue Feb 27, 2014 · 3 comments
Labels

Comments

@jlouis
Copy link
Collaborator

jlouis commented Feb 27, 2014

If we move all tests into one suite with adequate groups, we don't have to start/stop emysql pools all the time and we can speed up the test case. Also, it would enable us to have correct handling of coverage which would be very nice to have.

@jlouis jlouis added the Enhance label Feb 27, 2014
@hdiedrich
Copy link
Collaborator

+1 on coverage. Not sure about relevance of test run time?

@jlouis
Copy link
Collaborator Author

jlouis commented Feb 27, 2014

Currently, the tests run pretty fast, but one of the things we can do is to mark the suite as parallel and run it 2-3 times. This will probably be efficient at uncovering bugs pertaining to concurrent access in the code base. I can't do that as long as the suites are running each on their own.

@jlouis
Copy link
Collaborator Author

jlouis commented Feb 27, 2014

I have pushed some patches which addresses this partially. The code is covered somewhere between 40-80% depending on module. There are still more work to do, but it is a start.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants